Fencing configuration should be automatically generated

[Chris Jones]

t-h-t already has a mechanism for configuring fence agents on overcloud nodes, if EnableFencing is true, and an appropriate FencingConfig is passed in.

It should really be possible for the deployment to figure out the FencingConfig for itself.

[Chris Jones (cmsj)]

Patch is at https://review.openstack.org/417898 adding some tests at the moment.

[Chris Jones (cmsj)]

For virtual deployments, I've worked up some patches to add support for fence_ironic, to avoid complex networking changes for fence_xvm:

https://review.openstack.org/#/c/390397
https://review.openstack.org/#/c/390396

In the last month or so, OOOQ has introduced VirtualBMC, so virt deployments using quickstart will not actually use fence_ironic, but since this is (afaik) not the case with the core tripleo deployment tooling, fence_ironic support is probably desirable for dev/test situations.

There's also one tiny patch to allow fence_ipmilan to be called with nonstandard UDP ports so it can talk to VirtualBMC:

https://review.openstack.org/#/c/420917

Feel free to ping me on IRC (Ng) if you want to discuss anything :)

[Chris Jones (cmsj)]

Testing code is now in the review.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/422321

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/390397
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=e93527becf5e2ae02f52a8b8bcdc70f07167fdf8
Submitter: Jenkins
Branch: master

commit e93527becf5e2ae02f52a8b8bcdc70f07167fdf8
Author: Chris Jones <email address hidden>
Date: Mon Oct 24 21:04:11 2016 +0100

    Add support for fence_ironic fencing agent.

    We now support creating Pacemaker stonith fencing using the fence_ironic
    fencing agent.

    Partial-Bug: #1649695

    Depends-On: I315f9bb78a1296f691dadaeb39fb0a48df1d5f06
    Change-Id: I596eef68820f16516feeda147d3689f0da85d7ac

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/422321
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=6dcef35ab8a8ae275cd9337f82f9f05a6bdbdf92
Submitter: Jenkins
Branch: master

commit 6dcef35ab8a8ae275cd9337f82f9f05a6bdbdf92
Author: Chris Jones <email address hidden>
Date: Wed Jan 18 23:26:32 2017 +0000

    Add action for generating fencing parameters.

    We can now automatically generate environment parameters for fencing,
    post-deployment.

    Partial-Bug: #1649695

    Depends-On: I4f22c84fb65c7bba6904c174ff6819c6eaee0c32
    Change-Id: I0ff173b6daf770329b25f61b76fcba0e28b2550a

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/417898
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=eb4686cfc13b0c21b4be485d0f1cefb10818c2a8
Submitter: Jenkins
Branch: master

commit eb4686cfc13b0c21b4be485d0f1cefb10818c2a8
Author: Chris Jones <email address hidden>
Date: Thu Dec 15 21:07:16 2016 +0000

    Add overcloud_parameters.GenerateFencingParameters.

    We can now generate parameters to enable HA fencing, by re-consuming the
    instackenv.json file and introspecting the deployed stack.

    Closes-Bug: #1649695

    Depends-On: I0ff173b6daf770329b25f61b76fcba0e28b2550a
    Change-Id: I8b717b069f95cac20fe2d8c7fdaaacc46214957b

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 6.0.0 release.