Unable to sync plugin after syncing with new plugin_name

[Ekaterina Khomyakova]

Fuel 9.2 #600

Steps to reproduce:
  1. Install any plugin to fuel master node
  2. Change name to any other in metadata (/var/www/nailgun/plugins/${plugin}/metadata.yaml)
  3. `fuel plugins --sync` (Plugins were successfully synchronized.)
  4. `fuel plugins --sync`

Expected results:
  Plugins were successfully synchronized.

Actual result:
  500 Server Error: Internal Server Error for url: http://10.109.0.2:8000/api/v1/plugins/sync/ (Unexpected exception, please check logs)

logs:
  ...
  File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/session.py", line 214, in _assert_active
    % self._rollback_exception
InvalidRequestError: This Session's transaction has been rolled back due to a previous exception during flush. To begin a new transaction with this Session, first issue Session.rollback(). Original exception was: (psycopg2.IntegrityError) duplicate key value violates unique constraint "_name_version_unique"
DETAIL: Key (name, version)=(fuel-plugin, 3.2.0) already exists.
 [SQL: 'INSERT INTO plugins (name, title, version, description, releases, fuel_version, groups, authors, licenses, homepage, package_version, is_hotpluggable) VALUES (%(name)s, %(title)s, %(version)s, %(description)s, %(releases)s, %(fuel_version)s, %(groups)s, %(authors)s, %(licenses)s, %(homepage)s, %(package_version)s, %(is_hotpluggable)s) RETURNING plugins.id'] [parameters: {'name': 'fuel-plugin', 'releases': '[{"repository_path": "repositories/ubuntu", "version": "mitaka-9.0", "os": "ubuntu", "mode": ["ha"], "deployment_scripts_path": "deployment_scripts/"}]', 'title': '...', 'package_version': '4.0.0', 'is_hotpluggable': False, 'version': '3.2.0', 'fuel_version': '["9.0"]', 'groups': '["network"]', 'authors': '["..."]', 'licenses': '["..."]', 'homepage': '...', 'description': '...'}]

Additional information:
  Even if you remove plugin, this error will appear after second --sync. Workaround is to remove directory with plugin (/var/www/nailgun/plugins/${plugin}). But after this you can not install rpm with this plugin anymore.

[Ekaterina Khomyakova (ekhomyakova)]

Seems this bug is related: https://bugs.launchpad.net/fuel/+bug/1644469

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/414207

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/414207
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=f7debcb38d63e6c3f9f38fa9d8bb4e7457d7cf91
Submitter: Jenkins
Branch: master

commit f7debcb38d63e6c3f9f38fa9d8bb4e7457d7cf91
Author: Alexander Kislitsky <email address hidden>
Date: Thu Dec 22 18:47:09 2016 +0300

    Plugin rename is denied

    Plugin name is uses as identifier in sync operations. Plugins data
    on the file system can be found only by it's name, so renaming of
    the plugin must be denied.

    Change-Id: I2864537770f27d3b95d0d093900c1a787fef107c
    Closes-Bug: #1649568

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/418315

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/418316

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/418316
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=849031ecd8083822ce586ab9f212775e80e014c9
Submitter: Jenkins
Branch: stable/newton

commit 849031ecd8083822ce586ab9f212775e80e014c9
Author: Alexander Kislitsky <email address hidden>
Date: Thu Dec 22 18:47:09 2016 +0300

    Plugin rename is denied

    Plugin name is uses as identifier in sync operations. Plugins data
    on the file system can be found only by it's name, so renaming of
    the plugin must be denied.

    Change-Id: I2864537770f27d3b95d0d093900c1a787fef107c
    Closes-Bug: #1649568
    (cherry picked from commit f7debcb38d63e6c3f9f38fa9d8bb4e7457d7cf91)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/418315
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=1fb731d26161eb47dbe880003145901fb9f65e11
Submitter: Jenkins
Branch: stable/mitaka

commit 1fb731d26161eb47dbe880003145901fb9f65e11
Author: Alexander Kislitsky <email address hidden>
Date: Thu Dec 22 18:47:09 2016 +0300

    Plugin rename is denied

    Plugin name is uses as identifier in sync operations. Plugins data
    on the file system can be found only by it's name, so renaming of
    the plugin must be denied.

    Change-Id: I2864537770f27d3b95d0d093900c1a787fef107c
    Closes-Bug: #1649568
    (cherry picked from commit f7debcb38d63e6c3f9f38fa9d8bb4e7457d7cf91)

[Ekaterina Shutova (eshutova)]

Verified on 9.2 snapshot #750.
Got ERROR when trying to synchronize:
[root@nailgun ~]# fuel plugins --sync
400 Client Error: Bad Request for url: http://10.109.15.2:8000/api/v1/plugins/sync/ (Plugin can't be renamed. Trying to change name of the plugin fuel_plugin_hidden to fuel_plugin_hidden_01)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-web 11.0.0.0rc1 release candidate.

[Ekaterina Khomyakova (ekhomyakova)]

Verified on Fuel 10 #1575