[trunk] Neutron dbsync fails on overcloud deploy due to bigswitch plugin

[John Trowbridge]

We probably shouldn't be installing vendor plugins in the default image YAML. We had a similar problem with the cisco plugin a few weeks ago.

Logs:

2016-12-12 13:44:12,412 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: Traceback (most recent call last):
2016-12-12 13:44:12,413 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: File "/usr/bin/neutron-db-manage", line 10, in <module>
2016-12-12 13:44:12,413 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: sys.exit(main())
2016-12-12 13:44:12,413 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: File "/usr/lib/python2.7/site-packages/neutron/db/migration/cli.py", line 686, in main
2016-12-12 13:44:12,413 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: return_val |= bool(CONF.command.func(config, CONF.command.name))
2016-12-12 13:44:12,413 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: File "/usr/lib/python2.7/site-packages/neutron/db/migration/cli.py", line 205, in do_upgrade
2016-12-12 13:44:12,413 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: run_sanity_checks(config, revision)
2016-12-12 13:44:12,413 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: File "/usr/lib/python2.7/site-packages/neutron/db/migration/cli.py", line 670, in run_sanity_checks
2016-12-12 13:44:12,414 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: script_dir.run_env()
2016-12-12 13:44:12,414 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: File "/usr/lib/python2.7/site-packages/alembic/script/base.py", line 407, in run_env
2016-12-12 13:44:12,414 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: util.load_python_file(self.dir, 'env.py')
2016-12-12 13:44:12,414 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: File "/usr/lib/python2.7/site-packages/alembic/util/pyfiles.py", line 93, in load_python_file
2016-12-12 13:44:12,414 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: module = load_module_py(module_id, path)
2016-12-12 13:44:12,414 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: File "/usr/lib/python2.7/site-packages/alembic/util/compat.py", line 79, in load_module_py
2016-12-12 13:44:12,414 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: mod = imp.load_source(module_id, path, fp)
2016-12-12 13:44:12,414 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: File "/usr/lib/python2.7/site-packages/bsnstacklib/plugins/bigswitch/db/migration/alembic_migrations/env.py", line 20, in <module>
2016-12-12 13:44:12,415 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: from neutron.db import model_base
2016-12-12 13:44:12,415 INFO: Notice: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]/returns: ImportError: cannot import name model_base
2016-12-12 13:44:12,415 INFO: Error: /Stage[main]/Neutron::Db::Sync/Exec[neutron-db-sync]: Failed to call refresh: neutron-db-manage upgrade heads returned 1 instead of one of [0]

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/409809

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/409809
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=ec78e9d84d13de60b54368dd751a338d8c9af73b
Submitter: Jenkins
Branch: master

commit ec78e9d84d13de60b54368dd751a338d8c9af73b
Author: John Trowbridge <email address hidden>
Date: Mon Dec 12 09:19:14 2016 -0500

    Remove remaining vendor plugins from default image YAML

    Trunk is again broken by a vendor plugin not keeping up with
    deprecations in neutron. This time it is the bigswitch plugin
    that is using code from neutron that was moved to neutron-lib.

    There is not really any reason to have these vendor plugins
    installed in the default YAML. If the vendor wants to build images
    for TripleO in their own CI, it is simply a matter of passing an
    extra yaml with the packages key.

    Change-Id: Ib7c10f2dbd692494bd1990c3a2988308096743e7
    Closes-Bug: 1649284

[mathieu bultel (mat-bultel)]

I have made this fix for this issue:
https://review.openstack.org/419422

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/424152

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/424152
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=d9efb1f3311e3b8655cec335193c0f15e63c1ab9
Submitter: Jenkins
Branch: stable/newton

commit d9efb1f3311e3b8655cec335193c0f15e63c1ab9
Author: John Trowbridge <email address hidden>
Date: Mon Dec 12 09:19:14 2016 -0500

    Remove remaining vendor plugins from default image YAML

    Trunk is again broken by a vendor plugin not keeping up with
    deprecations in neutron. This time it is the bigswitch plugin
    that is using code from neutron that was moved to neutron-lib.

    There is not really any reason to have these vendor plugins
    installed in the default YAML. If the vendor wants to build images
    for TripleO in their own CI, it is simply a matter of passing an
    extra yaml with the packages key.

    Change-Id: Ib7c10f2dbd692494bd1990c3a2988308096743e7
    Closes-Bug: 1649284
    (cherry picked from commit ec78e9d84d13de60b54368dd751a338d8c9af73b)
    Related-Bug: 1658645

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 5.8.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 5.4.2 release.