Tripleo-Heat-Template, example for NeutronSriovNumVFs causes parsing error

[Sanjay Upadhyay]

As per the file - puppet/services/neutron-sriov-agent.yaml

 40 NeutronSriovNumVFs:
 41 description: >
 42 Provide the list of VFs to be reserved for each SR-IOV interface.
 43 Format "<interface_name1>:<numvfs1>","<interface_name2>:<numvfs2>"
 44 Example "eth1:4096","eth2:128"
 45 type: comma_delimited_list
 46 default: ""

However if we give a parameter as - "eth1:4096","eth2:128" - it throws a parse error as below -

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/osc_lib/shell.py", line 135, in run
    ret_val = super(OpenStackShell, self).run(argv)
  File "/usr/lib/python2.7/site-packages/cliff/app.py", line 267, in run
    result = self.run_subcommand(remainder)
  File "/usr/lib/python2.7/site-packages/osc_lib/shell.py", line 180, in run_subcommand
    ret_value = super(OpenStackShell, self).run_subcommand(argv)
  File "/usr/lib/python2.7/site-packages/cliff/app.py", line 387, in run_subcommand
    result = cmd.run(parsed_args)
  File "/usr/lib/python2.7/site-packages/osc_lib/command/command.py", line 41, in run
    return super(Command, self).run(parsed_args)
  File "/usr/lib/python2.7/site-packages/cliff/command.py", line 59, in run
    return self.take_action(parsed_args) or 0
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 1192, in take_action
    self._deploy_tripleo_heat_templates_tmpdir(stack, parsed_args)
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 412, in _deploy_tripleo_heat_templates_tmpdir
    new_tht_root, tht_root)
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 478, in _deploy_tripleo_heat_templates
    cleanup=not parsed_args.no_cleanup)
  File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 171, in _process_multiple_environments
    env_path=env_path)
  File "/usr/lib/python2.7/site-packages/heatclient/common/template_utils.py", line 303, in process_environment_and_files
    env = environment_format.parse(raw_env)
  File "/usr/lib/python2.7/site-packages/heatclient/common/environment_format.py", line 45, in parse
    raise ValueError(yea)
ValueError: while parsing a block mapping
  in "<string>", line 46, column 3:
      InternalApiNetCidr: 10.10.125.0/24
      ^
expected <block end>, but found ','
  in "<string>", line 87, column 46:
     ... icalDevMappings: "eth1:4096","eth2:128"

--

The resolution is to pass the parameter as "eth1:4096,eth2:128"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/408511

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/408511
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5de29f8e31321f370b1a95091a51ebfc088a9143
Submitter: Jenkins
Branch: master

commit 5de29f8e31321f370b1a95091a51ebfc088a9143
Author: Sanjay Upadhyay <email address hidden>
Date: Thu Dec 8 14:54:10 2016 +0530

    Correction to SRIOV THT Examples

    example for
     - NeutronSriovNumVFs
     - NeutronPhysicalDevMappings
    as given, causes parsing error.

    Change-Id: I71fb42f10dac70afa02244cd6629b3439f418d63
    Closes-Bug: #1648351

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0rc1 release candidate.