Plugin sync/update does not remove legacy tasks

[Evgeniy L]

Detailed bug description:
If plugins has tasks.yaml and in second version it was emptied, Nailgun does not remove them from database.
Steps to reproduce:
 Create plugin with tasks in tasks.yaml file.
 Install it on the environment.
 Create second version of the same plugin, but now remove tasks.yaml or make it empty.
 Update installed plugin, or run `fuel plugins --sync`
Expected results:
 Tasks removed.
Actual result:
 Tasks were not removed.
Reproducibility:
 100%
Workaround:
 Set '[]' for tasks field in database.
Impact:
 Breaks plugins updates for many users.
Description of the environment:
 Fuel: 9.1

[Evgeniy L (rustyrobot)]

Just for the history, there was a fix, but it does not fix the problem https://review.openstack.org/#/c/378574/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/408300

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/408300
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=daa2799ab49d6dd610ae3266b44a225b121c5ae1
Submitter: Jenkins
Branch: master

commit daa2799ab49d6dd610ae3266b44a225b121c5ae1
Author: Evgeny L <email address hidden>
Date: Tue Dec 6 17:59:00 2016 +0000

    Set legacy tasks to empty if file is removed or empty

    During plugin synchronisation or plugin update, if legacy
    tasks (tasks.yaml) are removed, they should be set to empty
    value [] in the database.

    Closes-bug: #1648223
    Related-bug: #1626855
    Change-Id: I4c6a61eb6ac0bb4395b843c4ba7df5bcd8ab2f7b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/415269

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/415270

[Aleksey Kasatkin (alekseyk-ru)]

Fix for 9.2 is on its way, so "in progress" for now.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/415269
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=293764c84c605f8a1f658e347feb6f2c9dafdffa
Submitter: Jenkins
Branch: stable/mitaka

commit 293764c84c605f8a1f658e347feb6f2c9dafdffa
Author: Evgeny L <email address hidden>
Date: Tue Dec 6 17:59:00 2016 +0000

    Set legacy tasks to empty if file is removed or empty

    During plugin synchronisation or plugin update, if legacy
    tasks (tasks.yaml) are removed, they should be set to empty
    value [] in the database.

    Closes-bug: #1648223
    Related-bug: #1626855
    Change-Id: I4c6a61eb6ac0bb4395b843c4ba7df5bcd8ab2f7b
    (cherry picked from commit daa2799ab49d6dd610ae3266b44a225b121c5ae1)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/415270
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=6c2167efc4c4f7caa423ee41345113f5a6d92d76
Submitter: Jenkins
Branch: stable/newton

commit 6c2167efc4c4f7caa423ee41345113f5a6d92d76
Author: Evgeny L <email address hidden>
Date: Tue Dec 6 17:59:00 2016 +0000

    Set legacy tasks to empty if file is removed or empty

    During plugin synchronisation or plugin update, if legacy
    tasks (tasks.yaml) are removed, they should be set to empty
    value [] in the database.

    Closes-bug: #1648223
    Related-bug: #1626855
    Change-Id: I4c6a61eb6ac0bb4395b843c4ba7df5bcd8ab2f7b
    (cherry picked from commit daa2799ab49d6dd610ae3266b44a225b121c5ae1)

[Ekaterina Khomyakova (ekhomyakova)]

Verified on Fuel 9.2 #801

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-web 11.0.0.0rc1 release candidate.