Move generation of mariadb systemd drop-in to puppet-tripleo

[Damien Ciabrini]

Systemd starts mariadb as user mysql, so in order to allow a large
number of connections (e.g. max_connections=4096) it is necessary to
raise the file descriptor limit via a system drop-in file.

When installing an undercloud, such drop-in file is currently
generated by instack-undercloud (in file puppet-stack-config.pp). But
non-HA overcloud also need such drop-in to be generated.

In order to avoid duplicating code, the drop-in creation code should
be provided by puppet-tripleo, and then used accordingly by
instack-undercloud or tripleo-heat-template (resp. to create
the undercloud or a non-HA overcloud).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/408250

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/435081

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/438600

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/438600
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=910a88f1ef16b63a9428f813b3ce2da918ea3aef
Submitter: Jenkins
Branch: master

commit 910a88f1ef16b63a9428f813b3ce2da918ea3aef
Author: Tim Rozet <email address hidden>
Date: Mon Feb 27 11:23:43 2017 -0500

    Adds puppet-systemd

    This puppet module is needed to manipulate systemd unit files and set
    limits needed for MariaDB.

    Partial-Bug: #1648181
    Related-Bug: #1524809

    Change-Id: I7ca7b5f7614971455cae2bf7c4bf8264b642b0dc
    Signed-off-by: Tim Rozet <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/439806

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/439806
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=bb18776dae74406fbf8bd49627abc24f8ad5952d
Submitter: Jenkins
Branch: stable/ocata

commit bb18776dae74406fbf8bd49627abc24f8ad5952d
Author: Tim Rozet <email address hidden>
Date: Mon Feb 27 11:23:43 2017 -0500

    Adds puppet-systemd

    This puppet module is needed to manipulate systemd unit files and set
    limits needed for MariaDB.

    Partial-Bug: #1648181
    Related-Bug: #1524809

    Change-Id: I7ca7b5f7614971455cae2bf7c4bf8264b642b0dc
    Signed-off-by: Tim Rozet <email address hidden>
    (cherry picked from commit 910a88f1ef16b63a9428f813b3ce2da918ea3aef)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/408250
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=09665170f6d0f4536a48dd4d1444e07aa064bed7
Submitter: Jenkins
Branch: master

commit 09665170f6d0f4536a48dd4d1444e07aa064bed7
Author: Damien Ciabrini <email address hidden>
Date: Wed Dec 7 19:09:06 2016 +0100

    mariadb: Move generation of systemd drop-in to puppet-tripleo

    Systemd starts mariadb as user mysql, so in order to allow a large
    number of connections (e.g. max_connections=4096) it is necessary to
    raise the file descriptor limit via a system drop-in file.

    When installing an undercloud, such drop-in file is currently
    generated by instack-undercloud (in file puppet-stack-config.pp). But
    non-HA overcloud also need such drop-in to be generated.

    In order to avoid duplicating code, the drop-in creation code should
    be provided by puppet-tripleo. By default, no drop-in is generated;
    it has to be enabled by instack-undercloud or tripleo-heat-template
    once they will use it (resp. to create undercloud or non-HA overcloud).

    This patch does not aim at generating a dynamic file limit based on
    the number of connections, this should land in another dedicated
    patch. Instead, it just reuses the limit currently set for undercloud
    and HA-overclouds.

    Also, the generation of the drop-in does not force a mysql restart
    like it currently does in instack-undercloud, to avoid unexpected
    service disruption on a non-HA overcloud after a minor update.

    Co-Authored-By: Tim Rozet <email address hidden>

    Depends-On: I7ca7b5f7614971455cae2bf7c4bf8264b642b0dc

    Change-Id: Ia0907b2ab6062a93fb9363e39c86535a490fbaf6
    Partial-Bug: #1648181
    Related-Bug: #1524809

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/441471

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/441471
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=5d9d1c606ca9c0ddc396819f2426a00f625a3273
Submitter: Jenkins
Branch: stable/ocata

commit 5d9d1c606ca9c0ddc396819f2426a00f625a3273
Author: Damien Ciabrini <email address hidden>
Date: Wed Dec 7 19:09:06 2016 +0100

    mariadb: Move generation of systemd drop-in to puppet-tripleo

    Systemd starts mariadb as user mysql, so in order to allow a large
    number of connections (e.g. max_connections=4096) it is necessary to
    raise the file descriptor limit via a system drop-in file.

    When installing an undercloud, such drop-in file is currently
    generated by instack-undercloud (in file puppet-stack-config.pp). But
    non-HA overcloud also need such drop-in to be generated.

    In order to avoid duplicating code, the drop-in creation code should
    be provided by puppet-tripleo. By default, no drop-in is generated;
    it has to be enabled by instack-undercloud or tripleo-heat-template
    once they will use it (resp. to create undercloud or non-HA overcloud).

    This patch does not aim at generating a dynamic file limit based on
    the number of connections, this should land in another dedicated
    patch. Instead, it just reuses the limit currently set for undercloud
    and HA-overclouds.

    Also, the generation of the drop-in does not force a mysql restart
    like it currently does in instack-undercloud, to avoid unexpected
    service disruption on a non-HA overcloud after a minor update.

    Co-Authored-By: Tim Rozet <email address hidden>

    Depends-On: I7ca7b5f7614971455cae2bf7c4bf8264b642b0dc

    Change-Id: Ia0907b2ab6062a93fb9363e39c86535a490fbaf6
    Partial-Bug: #1648181
    Related-Bug: #1524809
    (cherry picked from commit 09665170f6d0f4536a48dd4d1444e07aa064bed7)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/443261

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/443312

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/443756

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/443756
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=c9acf8a687ea64686c1ecceeff45add014752121
Submitter: Jenkins
Branch: master

commit c9acf8a687ea64686c1ecceeff45add014752121
Author: Tim Rozet <email address hidden>
Date: Thu Mar 9 12:04:10 2017 -0500

    Fixes issues with raising mysql file limit

    Changes Include:
     - Adds spec testing
     - Only raise limits if nonha. puppet-systemd will restart the mariadb
       service which breaks ha deployments. Hence we only want to do this
       in noha.
     - Minor fix to hiera value refrenced not as parameter to mysql.pp

    Partial-Bug: #1648181
    Related-Bug: #1524809

    Co-Authored By: Feng Pan <email address hidden>

    Change-Id: Id063bf4b4ac229181b01f40965811cb8ac4230d5
    Signed-off-by: Tim Rozet <email address hidden>
    Signed-off-by: Feng Pan <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/447515

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/443261
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=47d59f4660928e03743573ce51d13e3f2e52d15a
Submitter: Jenkins
Branch: stable/newton

commit 47d59f4660928e03743573ce51d13e3f2e52d15a
Author: Tim Rozet <email address hidden>
Date: Mon Feb 27 11:23:43 2017 -0500

    Adds puppet-systemd

    This puppet module is needed to manipulate systemd unit files and set
    limits needed for MariaDB.

    Partial-Bug: #1648181
    Related-Bug: #1524809

    Change-Id: I7ca7b5f7614971455cae2bf7c4bf8264b642b0dc
    Signed-off-by: Tim Rozet <email address hidden>
    (cherry picked from commit 910a88f1ef16b63a9428f813b3ce2da918ea3aef)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/447515
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=5508557a8a7a2d193308a35f46a10041ee2403f0
Submitter: Jenkins
Branch: stable/ocata

commit 5508557a8a7a2d193308a35f46a10041ee2403f0
Author: Tim Rozet <email address hidden>
Date: Thu Mar 9 12:04:10 2017 -0500

    Fixes issues with raising mysql file limit

    Changes Include:
     - Adds spec testing
     - Only raise limits if nonha. puppet-systemd will restart the mariadb
       service which breaks ha deployments. Hence we only want to do this
       in noha.
     - Minor fix to hiera value refrenced not as parameter to mysql.pp

    Partial-Bug: #1648181
    Related-Bug: #1524809

    Co-Authored By: Feng Pan <email address hidden>

    Change-Id: Id063bf4b4ac229181b01f40965811cb8ac4230d5
    Signed-off-by: Tim Rozet <email address hidden>
    Signed-off-by: Feng Pan <email address hidden>
    (cherry picked from commit c9acf8a687ea64686c1ecceeff45add014752121)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/443312
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=094ddde297707f66b7bffb4da103e54362a658cd
Submitter: Jenkins
Branch: stable/newton

commit 094ddde297707f66b7bffb4da103e54362a658cd
Author: Damien Ciabrini <email address hidden>
Date: Wed Dec 7 19:09:06 2016 +0100

    mariadb: Move generation of systemd drop-in to puppet-tripleo

    Systemd starts mariadb as user mysql, so in order to allow a large
    number of connections (e.g. max_connections=4096) it is necessary to
    raise the file descriptor limit via a system drop-in file.

    When installing an undercloud, such drop-in file is currently
    generated by instack-undercloud (in file puppet-stack-config.pp). But
    non-HA overcloud also need such drop-in to be generated.

    In order to avoid duplicating code, the drop-in creation code should
    be provided by puppet-tripleo. By default, no drop-in is generated;
    it has to be enabled by instack-undercloud or tripleo-heat-template
    once they will use it (resp. to create undercloud or non-HA overcloud).

    This patch does not aim at generating a dynamic file limit based on
    the number of connections, this should land in another dedicated
    patch. Instead, it just reuses the limit currently set for undercloud
    and HA-overclouds.

    Also, the generation of the drop-in does not force a mysql restart
    like it currently does in instack-undercloud, to avoid unexpected
    service disruption on a non-HA overcloud after a minor update.

    Co-Authored-By: Tim Rozet <email address hidden>

    Depends-On: I7ca7b5f7614971455cae2bf7c4bf8264b642b0dc

    Change-Id: Ia0907b2ab6062a93fb9363e39c86535a490fbaf6
    Partial-Bug: #1648181
    Related-Bug: #1524809
    (cherry picked from commit 09665170f6d0f4536a48dd4d1444e07aa064bed7)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/435081
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=900ddfb27f0dd2afd8345d89a78b624f647b255d
Submitter: Jenkins
Branch: master

commit 900ddfb27f0dd2afd8345d89a78b624f647b255d
Author: Tim Rozet <email address hidden>
Date: Thu Feb 16 14:21:32 2017 -0500

    Enables increasing mariadb open files for noha deployments

    There is currently an issue where the max open files limit is hit with
    MariaDB in noha deployments, because it is defaulted to 1024 by system
    limits. In HA deployments the limit is bumped to 16384. This patch
    introduces a flag to be able to increase the limit to 16384 for noHA
    deployments.

    In the future we should change this to be an integer, and let the
    operator decide the setting. Since this setting is set in a different
    path for HA, we would need to implement a change that allows setting
    both (ha and nonha) via the same integer param.

    Depends-On: Ia0907b2ab6062a93fb9363e39c86535a490fbaf6

    Closes-Bug: #1648181
    Related-Bug: #1524809

    Change-Id: I95393fc798b833a8575afbff03ef74a839565c5e
    Signed-off-by: Tim Rozet <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/450003

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/450003
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6b33a77f3c0bd283ec34cdc69688eede5b60949d
Submitter: Jenkins
Branch: stable/ocata

commit 6b33a77f3c0bd283ec34cdc69688eede5b60949d
Author: Tim Rozet <email address hidden>
Date: Thu Feb 16 14:21:32 2017 -0500

    Enables increasing mariadb open files for noha deployments

    There is currently an issue where the max open files limit is hit with
    MariaDB in noha deployments, because it is defaulted to 1024 by system
    limits. In HA deployments the limit is bumped to 16384. This patch
    introduces a flag to be able to increase the limit to 16384 for noHA
    deployments.

    In the future we should change this to be an integer, and let the
    operator decide the setting. Since this setting is set in a different
    path for HA, we would need to implement a change that allows setting
    both (ha and nonha) via the same integer param.

    Depends-On: Ia0907b2ab6062a93fb9363e39c86535a490fbaf6

    Closes-Bug: #1648181
    Related-Bug: #1524809

    Change-Id: I95393fc798b833a8575afbff03ef74a839565c5e
    Signed-off-by: Tim Rozet <email address hidden>
    (cherry picked from commit 900ddfb27f0dd2afd8345d89a78b624f647b255d)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/451466

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/451466
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=88a65c9676acf2ecc75ffd258fc1c6351cc22976
Submitter: Jenkins
Branch: stable/newton

commit 88a65c9676acf2ecc75ffd258fc1c6351cc22976
Author: Tim Rozet <email address hidden>
Date: Thu Mar 9 12:04:10 2017 -0500

    Fixes issues with raising mysql file limit

    Changes Include:
     - Adds spec testing
     - Only raise limits if nonha. puppet-systemd will restart the mariadb
       service which breaks ha deployments. Hence we only want to do this
       in noha.
     - Minor fix to hiera value refrenced not as parameter to mysql.pp

    Partial-Bug: #1648181
    Related-Bug: #1524809

    Co-Authored By: Feng Pan <email address hidden>

    Change-Id: Id063bf4b4ac229181b01f40965811cb8ac4230d5
    Signed-off-by: Tim Rozet <email address hidden>
    Signed-off-by: Feng Pan <email address hidden>
    (cherry picked from commit c9acf8a687ea64686c1ecceeff45add014752121)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/452803

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/452803
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0303c83792126630eb15abed57e81261e59e9dc3
Submitter: Jenkins
Branch: stable/newton

commit 0303c83792126630eb15abed57e81261e59e9dc3
Author: Tim Rozet <email address hidden>
Date: Thu Feb 16 14:21:32 2017 -0500

    Enables increasing mariadb open files for noha deployments

    There is currently an issue where the max open files limit is hit with
    MariaDB in noha deployments, because it is defaulted to 1024 by system
    limits. In HA deployments the limit is bumped to 16384. This patch
    introduces a flag to be able to increase the limit to 16384 for noHA
    deployments.

    In the future we should change this to be an integer, and let the
    operator decide the setting. Since this setting is set in a different
    path for HA, we would need to implement a change that allows setting
    both (ha and nonha) via the same integer param.

    Depends-On: Ia0907b2ab6062a93fb9363e39c86535a490fbaf6

    Closes-Bug: #1648181
    Related-Bug: #1524809

    Change-Id: I95393fc798b833a8575afbff03ef74a839565c5e
    Signed-off-by: Tim Rozet <email address hidden>
    (cherry picked from commit 900ddfb27f0dd2afd8345d89a78b624f647b255d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.1.0 release.