pt-table-sync - incorrect return code on error

[Ryan Brothers]

The manual for pt-table-sync states that an exit code of 2 indicates "At least one table differed on the destination". In the below example, the error is an invalid username/password, but the return code is 2. Should this be a return code of 1 for "Internal Error"?

[test@test ~]$ pt-table-sync --dry-run h=127.0.0.1,P=3306,u=test,p=test,D=test1,t=table1 h=127.0.0.1,P=3306,u=test,p=test,D=test2
DBI connect('test1;host=127.0.0.1;port=3306;mysql_read_default_group=client','test',...) failed: Access denied for user 'test'@'127.0.0.1' (using password: YES) at /usr/bin/pt-table-sync line 2242.
[test@test ~]$ echo $?
2

[Sveta Smirnova (svetasmirnova)]

Thank you for the report.

Verified as described:

sveta@Thinkie:~/issues$ ~/src/percona-toolkit/bin/pt-table-sync --sync-to-master --dry-run h=127.0.0.1,P=13002,u=root,p=foo
DBI connect(';host=127.0.0.1;port=13002;mysql_read_default_group=client','root',...) failed: Access denied for user 'root'@'localhost' (using password: YES) at /home/sveta/src/percona-toolkit/bin/pt-table-sync line 2248.
sveta@Thinkie:~/issues$ echo $?
2
sveta@Thinkie:~/issues$ ~/src/percona-toolkit/bin/pt-table-sync --version
pt-table-sync 2.2.19

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-1402