response type checking ignores the empty string
Bug #1647880 reported by
Jamie Lennox
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
requests-mock |
Fix Released
|
Low
|
Jamie Lennox |
Bug Description
When creating a response we check that a user didn't pass bytes as text= or a string as content=
Unfortunately we check it with a straight bool(text) rather than a text is None check and so the empty string skips these checks. This could be confusing and will break a user anyway so it should be safe to merge.
Changed in requests-mock: | |
milestone: | none → 1.3 |
importance: | Undecided → Low |
To post a comment you must log in.
Fix proposed to branch: master /review. openstack. org/407770
Review: https:/