overcloud image upload doesn't honor --image-path

[Sai Sindhur Malleni]

overcloud image upload only works assumes that user executes the command from ~/images directory eben when --image-path option is passed leading to errors such as "The given file overcloud-full.vmlinuz is not a regular file". Checking if file exists succeeds as the code does
self._check_file_exists(os.path.join(parsed_args.image_path,
image)), however when we build images we do not use the parsed-args.image_path for the file location.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/407261
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=17b5d6cd4299cdc14e43039e8fa906ccb36497fb
Submitter: Jenkins
Branch: master

commit 17b5d6cd4299cdc14e43039e8fa906ccb36497fb
Author: Sai Sindhur Malleni <email address hidden>
Date: Tue Dec 6 12:10:51 2016 +1100

    Make overcloud image upload honor --image-path

    The openstack overcloud image upload command supports --image-path argument
    but the code assumes that the command is run from ~/images directory and fails
    otherwise with errors such a "The given file overcloud-full.vmlinuz is not a
    regular file".

    When the code checks if the image file exists we do not see this error as
    "self._check_file_exists(os.path.join(parsed_args.image_path,
    image))" uses the image_path from user passed arguments. However, when
    building the file name for uploading the image, the --image-path is
    neglected.

    This commit adds code to make the image upload command work from
    any directory as long as --image-path option is passed.

    Closes-Bug: #1647519

    Change-Id: I74a21d73da95e81c5270f7264c25eaee923ba9ba
    Co-Authored-By: Ben Nemec <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/434975

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/434975
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=a4cb75e80e61ca8b55a1275e91ed4bede65d653a
Submitter: Jenkins
Branch: stable/ocata

commit a4cb75e80e61ca8b55a1275e91ed4bede65d653a
Author: Sai Sindhur Malleni <email address hidden>
Date: Tue Dec 6 12:10:51 2016 +1100

    Make overcloud image upload honor --image-path

    The openstack overcloud image upload command supports --image-path argument
    but the code assumes that the command is run from ~/images directory and fails
    otherwise with errors such a "The given file overcloud-full.vmlinuz is not a
    regular file".

    When the code checks if the image file exists we do not see this error as
    "self._check_file_exists(os.path.join(parsed_args.image_path,
    image))" uses the image_path from user passed arguments. However, when
    building the file name for uploading the image, the --image-path is
    neglected.

    This commit adds code to make the image upload command work from
    any directory as long as --image-path option is passed.

    Closes-Bug: #1647519

    Change-Id: I74a21d73da95e81c5270f7264c25eaee923ba9ba
    Co-Authored-By: Ben Nemec <email address hidden>
    (cherry picked from commit 17b5d6cd4299cdc14e43039e8fa906ccb36497fb)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 6.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 7.0.0 release.