Juju Charms Collection
nova-compute package

nova-compute charm incorrectly sets reserved_host_memory at nova.conf instead of reserved_host_memory_mb

Bug #1646657 reported by JuanJo Ciarlante
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
nova-compute (Juju Charms Collection)
Fix Released
Medium
James Page
Juju Charms Collection 17.01

Bug Description

nova-compute charm exposes reserved_host_memory setting,
template has:

$ egrep -r reserved_host_memory templates/
templates/kilo/nova.conf:reserved_host_memory = {{ reserved_host_memory }}
templates/liberty/nova.conf:reserved_host_memory = {{ reserved_host_memory }}
templates/mitaka/nova.conf:reserved_host_memory = {{ reserved_host_memory }}

while the correct setting is:

curl -s http://docs.openstack.org/{icehouse,juno,kilo,liberty}/config-reference/content/list-of-compute-config-options.html|egrep -o reserved_host_memory.*=
reserved_host_memory_mb =
reserved_host_memory_mb =
reserved_host_memory_mb</code> = <em class=
reserved_host_memory_mb</code> = <em class=

Fix is pretty trivial.

James Page (james-page)
Changed in nova-compute (Juju Charms Collection):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → James Page (james-page)
milestone: none → 17.01
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-nova-compute (master)

Fix proposed to branch: master
Review: https://review.openstack.org/406078

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-nova-compute (stable/16.10)

Fix proposed to branch: stable/16.10
Review: https://review.openstack.org/406370

Changed in nova-compute (Juju Charms Collection):
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-nova-compute (master)

Reviewed: https://review.openstack.org/406078
Committed: https://git.openstack.org/cgit/openstack/charm-nova-compute/commit/?id=1338764a3138e6638737fd1eaa489829eda5aedd
Submitter: Jenkins
Branch: master

commit 1338764a3138e6638737fd1eaa489829eda5aedd
Author: James Page <email address hidden>
Date: Fri Dec 2 11:39:50 2016 +0000

    Correct use of reserved_host_memory{_mb}

    The charm templates use the invalid configuration option:

     reserved_host_memory

    to configure the reserved memory for a compute host; update
    this to:

     reserved_host_memory_mb

    to ensure that memory gets correctly reserved for the host.

    Change-Id: I7b8089b165fddc023305ee37efe95e571e8d2407
    Closes-Bug: #1646657

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-nova-compute (stable/16.10)

Reviewed: https://review.openstack.org/406370
Committed: https://git.openstack.org/cgit/openstack/charm-nova-compute/commit/?id=a5320d7d19851bed0719bf6755e68cb4ea9869ba
Submitter: Jenkins
Branch: stable/16.10

commit a5320d7d19851bed0719bf6755e68cb4ea9869ba
Author: James Page <email address hidden>
Date: Fri Dec 2 11:39:50 2016 +0000

    Correct use of reserved_host_memory{_mb}

    The charm templates use the invalid configuration option:

     reserved_host_memory

    to configure the reserved memory for a compute host; update
    this to:

     reserved_host_memory_mb

    to ensure that memory gets correctly reserved for the host.

    Change-Id: I7b8089b165fddc023305ee37efe95e571e8d2407
    Closes-Bug: #1646657

James Page (james-page)
Changed in nova-compute (Juju Charms Collection):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.