Use ClientRegister and Unregister API to find time for GR restart

[Ananth Suryanarayana]

Currently, client such as IFMap registers and unregisters from the XmppChannel when the READY/NOT_READY notifications are received. BGP also receives these notifications and handles them to update its data structures.

During GR Helper mode, we can use these notifications (Unregister) from the client to figure out when it is ready to restart xmpp state machine.. Instead, we use separate APIs which is unnecessary and also does not work correctly when clients behave differently (such as ifmap and bgp)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/26674
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/26675
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/26674
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/26675
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/26674
Committed: http://github.org/Juniper/contrail-controller/commit/fb7fdebe6079b8f1264ffd1d063c77a1edee834b
Submitter: Zuul (<email address hidden>)
Branch: R3.2

commit fb7fdebe6079b8f1264ffd1d063c77a1edee834b
Author: Ananth Suryanarayana <email address hidden>
Date: Thu Dec 1 12:27:18 2016 -0800

Remove redundant CloseInProgress logic from XmppChannelMux class

Currently, client such as IFMap registers and unregisters from the XmppChannel
when the READY/NOT_READY notifications are received. BGP also receives these
notifications and handles them to update its data structures.

During GR Helper mode, we can use these notifications (Unregister) from the
client to figure out when it is ready to restart xmpp state machine..
Instead, we use separate APIs which is unnecessary and also does not work
correctly when clients behave differently (such as ifmap and bgp)

Only after all registers clients have unregistered can we go ahead and restart
xmpp state machine for GR to resume.

Also update json to file build agent unit tests when xmpp code is modified.
Agent is an XmppClient and uses Xmpp code in order to communicate with
contrail-control over xmpp

Change-Id: I77521eaf836043a4f1813744072e50edcdbafef8
Closes-Bug: 1646614

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/26675
Committed: http://github.org/Juniper/contrail-controller/commit/9da3c0657192284d856b8cf98abf8b143a9e6b39
Submitter: Zuul (<email address hidden>)
Branch: master

commit 9da3c0657192284d856b8cf98abf8b143a9e6b39
Author: Ananth Suryanarayana <email address hidden>
Date: Thu Dec 1 12:27:18 2016 -0800

Remove redundant CloseInProgress logic from XmppChannelMux class

Currently, client such as IFMap registers and unregisters from the XmppChannel
when the READY/NOT_READY notifications are received. BGP also receives these
notifications and handles them to update its data structures.

During GR Helper mode, we can use these notifications (Unregister) from the
client to figure out when it is ready to restart xmpp state machine..
Instead, we use separate APIs which is unnecessary and also does not work
correctly when clients behave differently (such as ifmap and bgp)

Only after all registers clients have unregistered can we go ahead and restart
xmpp state machine for GR to resume.

Also update json to file build agent unit tests when xmpp code is modified.
Agent is an XmppClient and uses Xmpp code in order to communicate with
contrail-control over xmpp

Change-Id: I77521eaf836043a4f1813744072e50edcdbafef8
Closes-Bug: 1646614