Fuel library script disassmbles and reassembles bond even when it is not necessary

[Anatolii Neliubin]

Detailed bug description:
Fuel library script /etc/puppet/modules/l23network/lib/puppet/provider/l2_bond/lnx.rb disassembles and reassembles bond interfaces every time
Expected results:
Bond should not be reassembled when this procedure is not necessary
Impact:
Affects availability of OpenStack services
Description of the environment:
 Operation system: CentOS release 6.6 (Final)
 Versions of components: Fuel 7.0

Excerpt from the script:
        #todo(sv): inplement re-assembling only if it need
        #todo(sv): re-set only delta between reality and requested
        runtime_bond_state = !self.class.get_iface_state(@resource[:bond]).nil?
        runtime_slave_ports = self.class.get_sys_class("#{bond_prop_dir}/bonding/slaves", true)
        debug("Disassemble bond '#{@resource[:bond]}'")
        runtime_slave_ports.each do |eth|
          debug("Remove interface '#{eth}' from bond '#{@resource[:bond]}'")
          # for most bond options we should disassemble bond before re-configuration. In the kernel module documentation
          # says, that bond interface should be downed, but it's not enouth.
          self.class.set_sys_class("#{bond_prop_dir}/bonding/slaves", "-#{eth}")
        end

[Oleksiy Molchanov (omolchanov)]

Backporting l23network fix this issue, waiting for test results on customer's side.

[Denis Meltsaykin (dmeltsaykin)]

Oleksiy, any progress on the issue?

[Anatolii Neliubin (aneliubin)]

The customer did not agree testing this change on his environment.

[Denis Meltsaykin (dmeltsaykin)]

What is the change, BTW? I don't see any code-review link. Could someone please provide me with one?

[Anatolii Neliubin (aneliubin)]

The suggested change was to use the newest l23network:
[root@fuel ~]# git clone https://github.com/openstack/fuel-library.git
[root@fuel ~]# tar acvf ./l23network.tgz /etc/puppet/modules/l23network
[root@fuel ~]# cp -R fuel-library/deployment/puppet/l23network /etc/puppet/modules/

[Denis Meltsaykin (dmeltsaykin)]

I see. I'm going to close this as Won't Fix, since there is no single change which can be back ported and we are not going to fetch the whole l23network from master into stable/7.0.