On Hold count in dashboard header picks up paging state from circ history

[Josh Stompro]

EG 2.10.6

Hello, I just noticed that if I look at my circ history in the catalog after clicking next a few times to show the next set of results, and then click on the "X On Hold" link in the dashboard header, it grabs the current paging state and applies it to the holds screen. This causes problems because there may be no results for the various lists, which presents a blank list to the user.

I cannot think how this would be useful, unless I'm already on the holds screen and I've already changed which results I'm looking at. And I personally would be fine with the dashboard links always returning to default settings.

The same thing seems to happen with the "Ready for Pickup" and "Fines" links. The "Checked Out" link doesn't seem to have that problem.

It looks like the dashboard code sets which variables should be cleared out for each link. The checked out link clears the 'limit' and 'offset' vars, so those don't get passed on. But the other 3 links don't clear those.

So one fix would be to add 'limit' and 'offset' to the other links, that would be simple. If the links should keep the limit and offset state in some cases, then there could be a conditional block that changes which mkurl args get set if the current page matches the link context.

Template code at: http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/templates/opac/parts/topnav.tt2;hb=HEAD#l45

To Test:
1. Log into catalog with a user that has more than 15 history and has less than 15 holds.
2. View history and click next to view the next set of results.
3. Hover over the holds dashboard link and see that limit and offset are set.
4. Click on holds link and see that no results are shown because of the paging settings.

Josh

[Michele Morgan (mmorgan)]

Setting this to Confirmed. Still an issue on 3.0.9. This has caused some confusion for patrons. One patron was unable to renew items after viewing their circulation history because they were not able to see their items out to select and renew them.