Dump all the instances from the db without paging when filter with ip and ip6 in server list

Bug #1646122 reported by Alex Xu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
In Progress
Low
int32bit

Bug Description

The filtering of ip and ip6 is done in the python. https://github.com/openstack/nova/blob/3cd2005523dc83b1cadc956c4f86385766aaf679/nova/compute/api.py#L2434

So all the instances dump from the db without paging
https://github.com/openstack/nova/blob/3cd2005523dc83b1cadc956c4f86385766aaf679/nova/compute/api.py#L2373

but that can be improved by still paging the db query. It will be better than dump all the instances in one db query.

Tags: api
Alex Xu (xuhj)
Changed in nova:
status: New → Confirmed
tags: added: api
Changed in nova:
importance: Undecided → High
int32bit (int32bit)
Changed in nova:
assignee: nobody → int32bit (int32bit)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/405171

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
Sean Dague (sdague) wrote :

This is a small performance increase, not a High bug

Changed in nova:
importance: High → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by int32bit (<email address hidden>) on branch: master
Review: https://review.openstack.org/405171

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.