NRPE check misfiring for qemu-kvm

[Adam Collard]

The nrpe checks that nova-compute charm sets up when related to nagios check that all the services comprising nova-compute are running, including qemu-kvm.

But qemu-kvm is a "one-shot" service that does the modprobes, and doesn't stay running, leaving the following error in Nagios:

CRITICAL: qemu-kvm.service is not running

On the machine in question

$ systemctl status qemu-kvm
● qemu-kvm.service - LSB: QEMU KVM module loading script
   Loaded: loaded (/etc/init.d/qemu-kvm; bad; vendor preset: enabled)
   Active: active (exited) since Tue 2016-11-29 12:15:01 UTC; 5h 48min ago
     Docs: man:systemd-sysv-generator(8)
    Tasks: 0
   Memory: 0B
      CPU: 0

Nov 29 12:15:01 fermi systemd[1]: Starting LSB: QEMU KVM module loading script...
Nov 29 12:15:01 fermi qemu-kvm[39777]: * Configuring kvm qemu-kvm
Nov 29 12:15:01 fermi qemu-kvm[39777]: ...done.
Nov 29 12:15:01 fermi systemd[1]: Started LSB: QEMU KVM module loading script.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/405343

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/405343
Committed: https://git.openstack.org/cgit/openstack/charm-nova-compute/commit/?id=8178cd4bdb35ffacd27620e3d8b81708de264786
Submitter: Jenkins
Branch: master

commit 8178cd4bdb35ffacd27620e3d8b81708de264786
Author: Alberto Donato <email address hidden>
Date: Thu Dec 1 11:56:21 2016 +0000

    Skip qemu-kvm from Nagios-monitored services

    The qemu-kvm service should not be configured as monitored in Nagios
    when the NRPE relation is set, since it's a one-shot service.

    Closes-Bug: #1645822
    Change-Id: I20b4eeb7971bae69f29183814e8c61a977e80bf0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/16.10
Review: https://review.openstack.org/405453

[Alberto Donato (ack)]

Released in cs:nova-compute-261

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/405453
Committed: https://git.openstack.org/cgit/openstack/charm-nova-compute/commit/?id=6a7571f2adafeb550cfc5206ba299ac898b5d361
Submitter: Jenkins
Branch: stable/16.10

commit 6a7571f2adafeb550cfc5206ba299ac898b5d361
Author: Alberto Donato <email address hidden>
Date: Thu Dec 1 11:56:21 2016 +0000

    Skip qemu-kvm from Nagios-monitored services

    The qemu-kvm service should not be configured as monitored in Nagios
    when the NRPE relation is set, since it's a one-shot service.

    Closes-Bug: #1645822
    Change-Id: I20b4eeb7971bae69f29183814e8c61a977e80bf0
    (cherry picked from commit 8178cd4bdb35ffacd27620e3d8b81708de264786)

[Ursula Junque (ursinha)]

Tested landscape-server r10805, nova-compute-262.
juju status on successfully deployed non-HA ceph/ceph cloud: https://pastebin.canonical.com/175521/

No critical error in nagios, the service check didn't run (as expected).