CI: problems with mistralclient/osprofiler on master

[Gabriele Cerami]

periodic jobs failing to install undercloud with this error, as seen in
http://logs.openstack.org/periodic/periodic-tripleo-ci-centos-7-ovb-nonha/9d5ea04/logs/undercloud/var/log/undercloud_install.txt.gz#_2016-11-28_06_33_33_000

2016-11-28 06:33:33.000 | Traceback (most recent call last):
2016-11-28 06:33:33.000 | File "<string>", line 1, in <module>
2016-11-28 06:33:33.000 | File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 1174, in install
2016-11-28 06:33:33.000 | _post_config(instack_env)
2016-11-28 06:33:33.000 | File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 1156, in _post_config
2016-11-28 06:33:33.000 | _post_config_mistral(instack_env, mistral)
2016-11-28 06:33:33.000 | File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 1126, in _post_config_mistral
2016-11-28 06:33:33.000 | _create_mistral_config_environment(instack_env, mistral)
2016-11-28 06:33:33.000 | File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 1073, in _create_mistral_config_environment
2016-11-28 06:33:33.000 | mistral.environments.get(env_name)
2016-11-28 06:33:33.000 | File "/usr/lib/python2.7/site-packages/mistralclient/api/v2/environments.py", line 80, in get
2016-11-28 06:33:33.000 | return self._get('/environments/%s' % name)
2016-11-28 06:33:33.000 | File "/usr/lib/python2.7/site-packages/mistralclient/api/base.py", line 117, in _get
2016-11-28 06:33:33.000 | resp = self.client.http_client.get(url)
2016-11-28 06:33:33.000 | File "/usr/lib/python2.7/site-packages/mistralclient/api/httpclient.py", line 32, in decorator
2016-11-28 06:33:33.000 | resp = func(self, *args, **kwargs)
2016-11-28 06:33:33.000 | File "/usr/lib/python2.7/site-packages/mistralclient/api/httpclient.py", line 72, in get
2016-11-28 06:33:33.000 | options = self._get_request_options('get', headers)
2016-11-28 06:33:33.000 | File "/usr/lib/python2.7/site-packages/mistralclient/api/httpclient.py", line 95, in _get_request_options
2016-11-28 06:33:33.000 | headers = self._update_headers(headers)
2016-11-28 06:33:33.000 | File "/usr/lib/python2.7/site-packages/mistralclient/api/httpclient.py", line 132, in _update_headers
2016-11-28 06:33:33.000 | headers.update(osprofiler_web.get_trace_id_headers())
2016-11-28 06:33:33.000 | AttributeError: 'NoneType' object has no attribute 'get_trace_id_headers'
2016-11-28 06:33:33.000 | Command 'instack-install-undercloud' returned non-zero exit status 1

[Gabriele Cerami (gcerami)]

python-mistralclient package was updated on 26th November, it points to pypi as source for the package. The problem is that the version pypi has been uploaded in august and is missing some fixes

https://pypi.python.org/pypi/python-mistralclient/2.1.1

[Gabriele Cerami (gcerami)]

bug was introduced https://review.rdoproject.org/r/#/c/3812/1/python-mistralclient.spec line 20

[Gabriele Cerami (gcerami)]

Last analysis was wrong. package is pinned for undercloud to the exact same version of pypi. The source0 in the package is ignore in DLRN builds.
We have to request a new release to upstream.

[Javier Peña (jpena-c)]

As Gabriele mentioned, that spec change is not causing the issue. When RDO Trunk builds packages for master, it ignores the Source0 URL and fetches the pinned version of the package from the git repo.

However, the spec change inadvertently removed the python-osprofiler dependency. That, combined with the fact that commit https://github.com/openstack/python-mistralclient/commit/d655e010b87c60cb62475324edfe3893c34ef711 is not yet in any tagged release, causes the error.

[Javier Peña (jpena-c)]

https://review.rdoproject.org/r/3916 should fix the issue from the packaging side.

[Gabriele Cerami (gcerami)]

This should fix the bug from upstream POV https://review.openstack.org/#/c/403656/

Thanks to everyone involved.