vip-hosts service puppet hosts entries delete data from the 'hosts' element

[Dan Prince]

I noticed a weird issue in trying to move away from the old 'hosts' element in tripleo-image-elements here:

https://review.openstack.org/#/c/400252/

It appears that the vip-hosts.yaml service uses puppet 'hosts' resources which causes the data in /etc/hosts to get removed. The only reason things work right now seems to be because os-refresh-config re-runs the 'hosts' element on each iteration thus re-creating the dropped entries.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/403448

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/403448
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=933f1afefd2ed6cf0f0395651f55fa25afbecad8
Submitter: Jenkins
Branch: master

commit 933f1afefd2ed6cf0f0395651f55fa25afbecad8
Author: Dan Prince <email address hidden>
Date: Fri Nov 25 11:20:57 2016 -0500

    Stop using puppet to configure VIPs in /etc/hosts

    This patch drops use of the vip-hosts.yaml service which can
    cause issues during deployment because puppet 'hosts' resources
    overwrite the data in /etc/hosts. The only reason things seem to work
    at all at the moment is because our hosts element in t-i-e runs
    on each os-refresh-config iteration and re-adds the dropped hosts
    entries.

    To work around the issue we add a conditional which selectively
    adds the extra hosts entries only if the AddVipsToEtcHosts is set
    to true.

    Closes-bug: 1645123

    Change-Id: Ic6aaeb249a127df83894f32a704219683a6382b2

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0b2 development milestone.