kdump-tools: Fails to load kdump kernel when /proc/cmdline contains double quotes

[Louis Bouchard]

[SRU justification]
This fix is needed to avoid failure to load kdump-tools when one kernel boot parameter has double-quotes.

[Impact]
kdump functionality becomes unusable

[Fix]
Modify kdump-config to handle the presence of double-quotes in the cmdline

[Test Case]
Edit /etc/default/grub and add the following to GRUB_CMDLINE_LINUX_DEFAULT :

\"acpi_osi=!Windows 2012\"
$ sudo update-grub
$ sudo reboot

kdump-config will show the following error upon reboot :

[ 11.595868] kdump-tools[1710]: Cannot open `2012 irqpoll nr_cpus=1 nousb systemd.unit=kdump-tools.service': No s
uch file or directory
[ 11.602563] kdump-tools[1710]: * failed to load kdump kernel

With this fix, the kdump-config command will run successfully

[Regression]
None expected. Fix is already in Zesty & Debian. Only one line added to the sed statement.

[Original description of the problem]
kdump-tools fails to load if one of the kernel parameter has double-quotes

[Louis Bouchard (louis)]

Debian bug for reference : https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=835600

[Timo Aaltonen (tjaalton)]

Hello Louis, or anyone else affected,

Accepted makedumpfile into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/makedumpfile/1:1.6.0-2ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Timo Aaltonen (tjaalton)]

Hello Louis, or anyone else affected,

Accepted makedumpfile into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/makedumpfile/1:1.5.9-5ubuntu0.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Launchpad Janitor (janitor)]

This bug was fixed in the package makedumpfile - 1:1.5.9-5ubuntu0.3

---------------
makedumpfile (1:1.5.9-5ubuntu0.3) xenial; urgency=medium

  * d/p/0003-PATCH-v2-Support-_count-_refcount-rename-in-struct-p.patch,
    d/p/0004-fix-readpage_elf-attempt-to-read-non-existent-page.patch
    Fix makedumpfile failure on 4.8 kernels.
     - Makedumpfile will exit on error with the following message :
       get_mem_map: Can't distinguish the memory type. (LP: #1626269)
     - Fix readpage_elf: Attempt to read non-existent page errors after
       previous patch is applied

  [ Rinat ]
  * Fix double-quote handling in /proc/cmdline
    Parsing of the cmdline would fail if double-quotes are encountered
    in /proc/cmdine (i.e. like when things like "acpi_osi=!Windows 2012"
    are found in the cmdline). (LP: #1644771)

  * Fix spelling error in debian/control

 -- Chris J Arges <email address hidden> Wed, 19 Oct 2016 07:41:36 -0500

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for makedumpfile has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package makedumpfile - 1:1.6.0-2ubuntu1.2

---------------
makedumpfile (1:1.6.0-2ubuntu1.2) yakkety; urgency=medium

  * d/p/0003-PATCH-v2-Support-_count-_refcount-rename-in-struct-p.patch,
    d/p/0004-fix-readpage_elf-attempt-to-read-non-existent-page.patch
    Fix makedumpfile failure on 4.8 kernels.
     - Makedumpfile will exit on error with the following message :
       get_mem_map: Can't distinguish the memory type. (LP: #1626269)
     - Fix readpage_elf: Attempt to read non-existent page errors after
       previous patch is applied

  [ Rinat ]
  * Fix double-quote handling in /proc/cmdline
    Parsing of the cmdline would fail if double-quotes are encountered
    in /proc/cmdine (i.e. like when things like "acpi_osi=!Windows 2012"
    are found in the cmdline). (LP: #1644771)

  * Fix spelling error in debian/control

 -- Louis Bouchard <email address hidden> Thu, 10 Nov 2016 16:46:39 +0100