Update tests according to a new serialization for NIC and Bond attributes

Bug #1644588 reported by Sergey Novikov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Sergey Novikov
Mitaka
Fix Released
High
Sergey Novikov
Newton
Fix Released
High
Sergey Novikov
Ocata
Fix Committed
High
Sergey Novikov

Bug Description

Detailed bug description:
We need to update code of fuel-qa tests according to a new serialization for NIC and Bond attributes https://review.openstack.org/#/c/356579/

new data structure for nics http://paste.openstack.org/show/590334/

Changed in fuel:
status: New → Confirmed
importance: Critical → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/404090

Changed in fuel:
importance: High → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (stable/mitaka)

Reviewed: https://review.openstack.org/404090
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=11783da6accf71590d1e8000f734c6cf3218ba6b
Submitter: Jenkins
Branch: stable/mitaka

commit 11783da6accf71590d1e8000f734c6cf3218ba6b
Author: Vladimir Khlyunev <email address hidden>
Date: Tue Nov 29 11:54:41 2016 +0300

    Update dpdk and sr-iov configuration methods with new api

    Serialization for features mentioned in title was changed so
    we have to use new fields

    Change-Id: If362a37fdb16d6672a266567490e67a22ba16f3e
    Partial-bug:1644588

tags: added: in-stable-mitaka
Changed in fuel:
assignee: Fuel QA Team (fuel-qa) → Sergey Novikov (snovikov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/408634

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (stable/mitaka)

Reviewed: https://review.openstack.org/408634
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=94e2fd57a2aab988bc6ac9ef7b870817061ea425
Submitter: Jenkins
Branch: stable/mitaka

commit 94e2fd57a2aab988bc6ac9ef7b870817061ea425
Author: Sergey Novikov <email address hidden>
Date: Thu Dec 8 18:06:33 2016 +0400

    Update offloading and MTU configuration due to a new API

    Change-Id: I958f0a8caf8dc8156c8a95381c94690b84ee7ae6
    Closes-Bug: 1644588

Changed in fuel:
status: Confirmed → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/411165

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (master)

Fix proposed to branch: master
Review: https://review.openstack.org/411166

Revision history for this message
Nastya Urlapova (aurlapova) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/414111

Revision history for this message
Tatyana Borukhovich (tatyanaborukhovich) wrote :

ETA: 12/23/2016

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/414916

Revision history for this message
Sergey Novikov (snovikov) wrote :

The fix has been proposed. but the merging of it depends directly from https://bugs.launchpad.net/fuel/+bug/1652068 .

Also, the issue affects only 2 tests, thus, I've lowered a priority

tags: added: swarm-fail
removed: swarm-blocker
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (stable/mitaka)

Reviewed: https://review.openstack.org/414111
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=452fe60d3de7c788fc042fe9c401331ee33c1add
Submitter: Jenkins
Branch: stable/mitaka

commit 452fe60d3de7c788fc042fe9c401331ee33c1add
Author: Sergey Novikov <email address hidden>
Date: Thu Dec 22 17:38:41 2016 +0400

    Update bond tests according to new iface serialization

    Change-Id: I9c3f4ffa504b582f52b510d62313b6b3b2c195b6
    Closes-Bug: 1651960
    Partial-Bug: 1644588

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/415145

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (master)

Fix proposed to branch: master
Review: https://review.openstack.org/415146

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (stable/mitaka)

Reviewed: https://review.openstack.org/414916
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=08332513d9cbc6cbf51c5e845a901c14bf66eae5
Submitter: Jenkins
Branch: stable/mitaka

commit 08332513d9cbc6cbf51c5e845a901c14bf66eae5
Author: Sergey Novikov <email address hidden>
Date: Mon Dec 26 13:36:06 2016 +0400

    Update offloading bond tests according to new iface serialization

    Change-Id: Ife57fe1465ff9754ab30915756631df0bf25ad4a
    Closes-Bug: 1644588

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/411166
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=3c7d662d95b1e8c804c92fbaae3f3b332b506689
Submitter: Jenkins
Branch: master

commit 3c7d662d95b1e8c804c92fbaae3f3b332b506689
Author: Sergey Novikov <email address hidden>
Date: Thu Dec 8 18:06:33 2016 +0400

    Update offloading and MTU configuration due to a new API

    Change-Id: I958f0a8caf8dc8156c8a95381c94690b84ee7ae6
    Closes-Bug: 1644588
    (cherry picked from commit 94e2fd57a2aab988bc6ac9ef7b870817061ea425)

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (stable/newton)

Reviewed: https://review.openstack.org/411165
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=2e6f0b6c4d48be66d495b87d9969d6117fe0f709
Submitter: Jenkins
Branch: stable/newton

commit 2e6f0b6c4d48be66d495b87d9969d6117fe0f709
Author: Sergey Novikov <email address hidden>
Date: Thu Dec 8 18:06:33 2016 +0400

    Update offloading and MTU configuration due to a new API

    Change-Id: I958f0a8caf8dc8156c8a95381c94690b84ee7ae6
    Closes-Bug: 1644588
    (cherry picked from commit 94e2fd57a2aab988bc6ac9ef7b870817061ea425)

Revision history for this message
Vladimir Khlyunev (vkhlyunev) wrote :

https://review.openstack.org/#/c/404090/ was not landed to stable/newton and master branches, reopening for 10.1 and 11 milestones

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/415146
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=5a5bd37868dc43071fb7ec2c1c63258367522f1a
Submitter: Jenkins
Branch: master

commit 5a5bd37868dc43071fb7ec2c1c63258367522f1a
Author: Sergey Novikov <email address hidden>
Date: Thu Dec 22 17:38:41 2016 +0400

    Update bond tests according to new iface serialization

    Change-Id: I9c3f4ffa504b582f52b510d62313b6b3b2c195b6
    Closes-Bug: 1651960
    Partial-Bug: 1644588
    (cherry picked from commit 452fe60d3de7c788fc042fe9c401331ee33c1add)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (stable/newton)

Reviewed: https://review.openstack.org/415145
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=06476e3cd1653f1c4776c925dab78d7ff9fa8b2e
Submitter: Jenkins
Branch: stable/newton

commit 06476e3cd1653f1c4776c925dab78d7ff9fa8b2e
Author: Sergey Novikov <email address hidden>
Date: Thu Dec 22 17:38:41 2016 +0400

    Update bond tests according to new iface serialization

    Change-Id: I9c3f4ffa504b582f52b510d62313b6b3b2c195b6
    Closes-Bug: 1651960
    Partial-Bug: 1644588
    (cherry picked from commit 452fe60d3de7c788fc042fe9c401331ee33c1add)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/418883

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (master)

Fix proposed to branch: master
Review: https://review.openstack.org/418884

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/418884
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=6bf6fcdeffeb9755c5728a364565084b75dac31d
Submitter: Jenkins
Branch: master

commit 6bf6fcdeffeb9755c5728a364565084b75dac31d
Author: Vladimir Khlyunev <email address hidden>
Date: Tue Nov 29 11:54:41 2016 +0300

    Update dpdk and sr-iov configuration methods with new api

    Serialization for features mentioned in title was changed so
    we have to use new fields

    Change-Id: If362a37fdb16d6672a266567490e67a22ba16f3e
    Partial-bug:1644588
    (cherry picked from commit 11783da6accf71590d1e8000f734c6cf3218ba6b)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (stable/newton)

Reviewed: https://review.openstack.org/418883
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=9fe049d348f37ce884738367e3e4ea833e6fb7f7
Submitter: Jenkins
Branch: stable/newton

commit 9fe049d348f37ce884738367e3e4ea833e6fb7f7
Author: Vladimir Khlyunev <email address hidden>
Date: Tue Nov 29 11:54:41 2016 +0300

    Update dpdk and sr-iov configuration methods with new api

    Serialization for features mentioned in title was changed so
    we have to use new fields

    Change-Id: If362a37fdb16d6672a266567490e67a22ba16f3e
    Partial-bug:1644588
    (cherry picked from commit 11783da6accf71590d1e8000f734c6cf3218ba6b)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/418957

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (master)

Fix proposed to branch: master
Review: https://review.openstack.org/418958

tags: added: on-verification
Revision history for this message
Dmitry Belyaninov (dbelyaninov) wrote :

As I undestand we use [0] functions for interfaces and bonds.
So ether ifaces format is correct:

        "attributes": {
            "offloading": {
                ...
                "modes": {
                    ...
                    "value": {
                        "rx-vlan-offload": null,

But for bondings it is:
        "meta": {
            "dpdk": {
                "available": true
            },
            "offloading": {
                "modes": [
                    {
                        "state": null,
                        "name": "rx-all",
                        "sub": []
                    },

So we should check type of iface "type": "ether" or "type": "bond" before iface offloading update.

There is failed swarm test case [1]

[0] get_offloading_modes, update_offloads
[1] https://product-ci.infra.mirantis.net/job/9.x.system_test.ubuntu.bonding_ha_one_controller/177/testReport/(root)/offloading_bond_neutron_vlan/offloading_bond_neutron_vlan/

Revision history for this message
Sergey Novikov (snovikov) wrote :

Thank you @Dmitry for clarification. The bonding format was updated by https://bugs.launchpad.net/fuel/+bug/1652068. So, we need to update tests and i will do it

tags: removed: on-verification
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/421343

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/421772

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (master)

Fix proposed to branch: master
Review: https://review.openstack.org/421773

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (stable/mitaka)

Reviewed: https://review.openstack.org/421343
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=5e4e3c2fad5bd2e04bbe2a6133d76a4f345ba144
Submitter: Jenkins
Branch: stable/mitaka

commit 5e4e3c2fad5bd2e04bbe2a6133d76a4f345ba144
Author: Sergey Novikov <email address hidden>
Date: Tue Jan 17 19:59:01 2017 +0400

    Update bond tests

    Juat another update of bond tests according to
    fix of https://bugs.launchpad.net/fuel/+bug/1652068

    Change-Id: I3c0b2dd09f54fefb52baef914047507fd9cc0511
    Closes-Bug: 1644588

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (stable/newton)

Reviewed: https://review.openstack.org/418957
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=477c22db140b8c98654e4d7ba918ad457e4a6ff6
Submitter: Jenkins
Branch: stable/newton

commit 477c22db140b8c98654e4d7ba918ad457e4a6ff6
Author: Sergey Novikov <email address hidden>
Date: Mon Dec 26 13:36:06 2016 +0400

    Update offloading bond tests according to new iface serialization

    Change-Id: Ife57fe1465ff9754ab30915756631df0bf25ad4a
    Closes-Bug: 1644588
    (cherry picked from commit 08332513d9cbc6cbf51c5e845a901c14bf66eae5)

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/418958
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=11cb6f767ebb483e4c9bebbee7c6dc9b48e53058
Submitter: Jenkins
Branch: master

commit 11cb6f767ebb483e4c9bebbee7c6dc9b48e53058
Author: Sergey Novikov <email address hidden>
Date: Mon Dec 26 13:36:06 2016 +0400

    Update offloading bond tests according to new iface serialization

    Change-Id: Ife57fe1465ff9754ab30915756631df0bf25ad4a
    Closes-Bug: 1644588
    (cherry picked from commit 08332513d9cbc6cbf51c5e845a901c14bf66eae5)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/421773
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=5297e50239beb978fe3a5be84eaa7463b9b54449
Submitter: Jenkins
Branch: master

commit 5297e50239beb978fe3a5be84eaa7463b9b54449
Author: Sergey Novikov <email address hidden>
Date: Tue Jan 17 19:59:01 2017 +0400

    Update bond tests

    Juat another update of bond tests according to
    fix of https://bugs.launchpad.net/fuel/+bug/1652068

    Change-Id: I3c0b2dd09f54fefb52baef914047507fd9cc0511
    Closes-Bug: 1644588

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (stable/newton)

Reviewed: https://review.openstack.org/421772
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=a957e78beb69b78dc9060b6c7b87f713f4f9b4e9
Submitter: Jenkins
Branch: stable/newton

commit a957e78beb69b78dc9060b6c7b87f713f4f9b4e9
Author: Sergey Novikov <email address hidden>
Date: Tue Jan 17 19:59:01 2017 +0400

    Update bond tests

    Juat another update of bond tests according to
    fix of https://bugs.launchpad.net/fuel/+bug/1652068

    Change-Id: I3c0b2dd09f54fefb52baef914047507fd9cc0511
    Closes-Bug: 1644588

Revision history for this message
Dmitry Belyaninov (dbelyaninov) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-qa 11.0.0.0rc1

This issue was fixed in the openstack/fuel-qa 11.0.0.0rc1 release candidate.

Revision history for this message
Vladimir Khlyunev (vkhlyunev) wrote :

Works fine at 1575 swarm

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.