[UI] weight property for plugin doesn't order NIC attributes

Bug #1644461 reported by Ekaterina Khomyakova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Julia Aranovich

Bug Description

Fuel 9.2 #549

nic_config.yaml:

attribute_checkbox:
  label: "NIC attribute Checkbox"
  description: "Description for Checkbox"
  type: "checkbox"
  value: false
  weight: 5
attribute_text:
  label: "NIC attribute Text"
  description: "Description for Text"
  type: "text"
  value: ""
  weight: 10

Steps to reproduce:
  1. Create env with plugin
  2. Add node, select it, press "Configure Interfaces"
  3. Expand attributes configuration provided by plugin

Expected results:
  Attributes should be represented in ascending order by their weights, so the first is Checkbox, on the next line is Text-input

Actual result:
  Text-input is first, on the next line is Checkbox

Changed in fuel:
status: New → Confirmed
importance: High → Medium
assignee: nobody → Fuel UI Team (fuel-ui)
tags: added: area-ui
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/406774

Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Julia Aranovich (jkirnosova)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (master)

Reviewed: https://review.openstack.org/406774
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=6c1c688e37890918b3a198d4c25e1087f0919de9
Submitter: Jenkins
Branch: master

commit 6c1c688e37890918b3a198d4c25e1087f0919de9
Author: Julia Aranovich <email address hidden>
Date: Mon Dec 5 11:38:03 2016 +0300

    Fix sorting of settings

    _.sortBy works improperly when returning array as a sorter.
    Numbers are sorted as strings in this case.

    Closes-Bug: #1644461

    Change-Id: I7642ae2af6b847bd7c3217700f6866c2aef307c9

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/408598

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-ui (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/408600

tags: added: on-verification
tags: removed: on-verification
tags: added: on-verification
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-ui (master)

Reviewed: https://review.openstack.org/408600
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=412f9a29cb895be6466f69bd32d0791f2e91b725
Submitter: Jenkins
Branch: master

commit 412f9a29cb895be6466f69bd32d0791f2e91b725
Author: Julia Aranovich <email address hidden>
Date: Thu Dec 8 16:47:18 2016 +0300

    Handle setting with undefined weight

    Related-Bug: #1644461

    Change-Id: I49fa28eb9aed96ec7aeed01d9d4d65363fe89d88

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-ui (stable/mitaka)

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/409638

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (stable/mitaka)

Reviewed: https://review.openstack.org/408598
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=cecf2f157f7f95afe80f19ff3ef6d2cecd17808f
Submitter: Jenkins
Branch: stable/mitaka

commit cecf2f157f7f95afe80f19ff3ef6d2cecd17808f
Author: Julia Aranovich <email address hidden>
Date: Mon Dec 5 11:38:03 2016 +0300

    Fix sorting of settings

    _.sortBy works improperly when returning array as a sorter.
    Numbers are sorted as strings in this case.

    Closes-Bug: #1644461

    Change-Id: I7642ae2af6b847bd7c3217700f6866c2aef307c9

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-ui (stable/mitaka)

Reviewed: https://review.openstack.org/409638
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=b2680c194bd3b5cabacd0635e0e2a53f53def2a0
Submitter: Jenkins
Branch: stable/mitaka

commit b2680c194bd3b5cabacd0635e0e2a53f53def2a0
Author: Julia Aranovich <email address hidden>
Date: Thu Dec 8 16:47:18 2016 +0300

    Handle setting with undefined weight

    Related-Bug: #1644461

    Change-Id: I49fa28eb9aed96ec7aeed01d9d4d65363fe89d88

Revision history for this message
ElenaRossokhina (esolomina) wrote :

Verified 9.2 snapshot #637

Changed in fuel:
status: Fix Committed → Fix Released
tags: removed: on-verification
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/415843

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (stable/newton)

Reviewed: https://review.openstack.org/415843
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=8a8cc2bde741c37799f7aef74b212ca17e655cf8
Submitter: Jenkins
Branch: stable/newton

commit 8a8cc2bde741c37799f7aef74b212ca17e655cf8
Author: Julia Aranovich <email address hidden>
Date: Mon Dec 5 11:38:03 2016 +0300

    Fix sorting of settings

    _.sortBy works improperly when returning array as a sorter.
    Numbers are sorted as strings in this case.

    Closes-Bug: #1644461

    Change-Id: I7642ae2af6b847bd7c3217700f6866c2aef307c9
    (cherry picked from commit 6c1c688e37890918b3a198d4c25e1087f0919de9)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-ui (stable/newton)

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/415852

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-ui (stable/newton)

Reviewed: https://review.openstack.org/415852
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=49aebe2fbab7852ec0c184d6554503d870405b0d
Submitter: Jenkins
Branch: stable/newton

commit 49aebe2fbab7852ec0c184d6554503d870405b0d
Author: Julia Aranovich <email address hidden>
Date: Thu Dec 8 16:47:18 2016 +0300

    Handle setting with undefined weight

    Related-Bug: #1644461

    Change-Id: I49fa28eb9aed96ec7aeed01d9d4d65363fe89d88
    (cherry picked from commit 412f9a29cb895be6466f69bd32d0791f2e91b725)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-ui 11.0.0.0rc1

This issue was fixed in the openstack/fuel-ui 11.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.