gate failure due to GUARD_TRANSACTION

[YAMAMOTO Takashi]

eg. http://logs.openstack.org/27/400627/5/check/gate-tempest-dsvm-networking-midonet-ml2-ubuntu-xenial/175d14d/logs/screen-q-svc.txt.gz?level=TRACE

2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource [req-1892c924-cc18-42c6-8df1-3ab95b786058 tempest-ExternalNetworksAdminNegativeTestJSON-706836894 -] create failed: No details.
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource Traceback (most recent call last):
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/api/v2/resource.py", line 79, in resource
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource result = method(request=request, **args)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/api/v2/base.py", line 430, in create
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource return self._create(request, body, **kwargs)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/db/api.py", line 92, in wrapped
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource setattr(e, '_RETRY_EXCEEDED', True)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource self.force_reraise()
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource six.reraise(self.type_, self.value, self.tb)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/db/api.py", line 88, in wrapped
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource return f(*args, **kwargs)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_db/api.py", line 151, in wrapper
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource ectxt.value = e.inner_exc
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource self.force_reraise()
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource six.reraise(self.type_, self.value, self.tb)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_db/api.py", line 139, in wrapper
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource return f(*args, **kwargs)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/db/api.py", line 128, in wrapped
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource traceback.format_exc())
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource self.force_reraise()
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource six.reraise(self.type_, self.value, self.tb)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/db/api.py", line 123, in wrapped
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource return f(*dup_args, **dup_kwargs)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/api/v2/base.py", line 543, in _create
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource obj = do_create(body)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/api/v2/base.py", line 525, in do_create
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource request.context, reservation.reservation_id)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource self.force_reraise()
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource six.reraise(self.type_, self.value, self.tb)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/api/v2/base.py", line 518, in do_create
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource return obj_creator(request.context, **kwargs)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_log/helpers.py", line 48, in wrapper
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource return method(*args, **kwargs)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/opt/stack/new/networking-midonet/midonet/neutron/services/l3/l3_midonet.py", line 216, in create_floatingip
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource context, floatingip)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/db/l3_db.py", line 1799, in create_floatingip
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource context, floatingip, initial_status)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/db/api.py", line 163, in wrapped
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource return method(*args, **kwargs)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/db/l3_db.py", line 1273, in create_floatingip
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource return self._create_floatingip(context, floatingip, initial_status)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/db/l3_db.py", line 1221, in _create_floatingip
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource check_allow_post=False)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/plugins/common/utils.py", line 183, in create_port
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource return core_plugin.create_port(context, {'port': port_data})
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource File "/opt/stack/new/neutron/neutron/common/utils.py", line 698, in inner
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource "transaction.") % f)
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource RuntimeError: Method <function create_port at 0x7f946dcc22a8> cannot be called within a transaction.
2016-11-23 08:39:45.949 24839 ERROR neutron.api.v2.resource

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/401272

[OpenStack Infra (hudson-openstack)]

Change abandoned by YAMAMOTO Takashi (<email address hidden>) on branch: master
Review: https://review.openstack.org/401272
Reason: folded into https://review.openstack.org/#/c/398562/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/398562
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=b905f315e497f1ad3460e0d6dd2d32ce1451a699
Submitter: Jenkins
Branch: master

commit b905f315e497f1ad3460e0d6dd2d32ce1451a699
Author: Armando Migliaccio <email address hidden>
Date: Wed Nov 16 11:56:18 2016 -0800

    Switch to using plugins directory in lieu of neutron manager

    The following changes were merged into this single commit
    to pass the gate.

    -------------------------------------

    Switch to using plugins directory in lieu of neutron manager

    Partially-implements: blueprint neutron-lib

    -------------------------------------

    L3: Add another GUARD_TRANSACTION

    Recently neutron removed GUARD_TRANSACTION for create_floaingip. [1]
    As we still have a surronding transaction, we need to tweak
    GUARD_TRANSACTION by ourselves.

    [1] Ia4c34c6654a5bfb64fbf06b11b0a29b018c6854f

    Closes-Bug: #1644236

    -------------------------------------

    update_port: Don't update N/A status

    update_port for floating-ip port is introduced by recent
    Neutron change. [2] Our automatic update of status field
    is not appropriate for floating-ip ports, where it's supposed
    to be N/A.

    [2] Ia4c34c6654a5bfb64fbf06b11b0a29b018c6854f

    Closes-Bug: #1644261

    -------------------------------------

    Skip test_list_firewalls_with_filtering

    This test has been merged recently. [3]
    It fails because it expects a newly created firewall is
    PENDING_CREATE, while our plugin set it to ACTIVE
    synchronously. Skip the test for now to unbreak the gate.
    REVISIT(yamamoto): Probably it's better to tweak the test,
    and/or mock our plugin to make it pass.

    [3] I5bcd148de524af802f01e4e5444a6e605318954f

    Closes-Bug: #1644500

    -------------------------------------

    Co-Authored-By: YAMAMOTO Takashi <email address hidden>
    Change-Id: I418a777463eb896ee6e19fe4d662943cc9772bf0

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-midonet 4.0.0 release.