api.Client.WatchDebugLog isn't cancellable
Bug #1644084 reported by
Christian Muirhead
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical Juju |
Expired
|
Low
|
Unassigned |
Bug Description
This is in the process of being moved to api/common.
If the caller stops reading from the channel (because it has an error, for example) the goroutine will be leaked. This is OK when used from the command line because the process will be going away soon in that case, but is a problem if it happens in jujud.
Change it to accept a stop channel and use a read deadline so that the client can stop it.
tags: | added: tech-debt |
Changed in juju: | |
status: | New → Triaged |
importance: | Undecided → Medium |
To post a comment you must log in.
As this is a tech-debt item, I am lowering its Importance.