api.Client.WatchDebugLog isn't cancellable

Bug #1644084 reported by Christian Muirhead
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Expired
Low
Unassigned

Bug Description

This is in the process of being moved to api/common.StreamDebugLogs so that it can be used in the migration log transfer phase.

If the caller stops reading from the channel (because it has an error, for example) the goroutine will be leaked. This is OK when used from the command line because the process will be going away soon in that case, but is a problem if it happens in jujud.

Change it to accept a stop channel and use a read deadline so that the client can stop it.

tags: added: tech-debt
Changed in juju:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Anastasia (anastasia-macmood) wrote :

As this is a tech-debt item, I am lowering its Importance.

Changed in juju:
importance: Medium → Low
Revision history for this message
Canonical Juju QA Bot (juju-qa-bot) wrote :

This bug has not been updated in 5 years, so we're marking it Expired. If you believe this is incorrect, please update the status.

Changed in juju:
status: Triaged → Expired
tags: added: expirebugs-bot
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.