[windows] makerelease fail if git can't find branch name

[Sébastien BLAISOT]

if we're on HEAD, scons defines branch name to "(no branch)".
https://github.com/mixxxdj/mixxx/blob/master/build/util.py#L94

This name breaks makerelease target under windows (see build log below)

We should at least surround package filename with quotes.

Using command: "C:\Program Files (x86)\NSIS\makensis.exe" /DPACKAGE_NAME=mixxx-2.1.0-alpha-pre-(no branch)-git6000-release-x64.exe /DPRODUCT_VERSION=2.1.0-alpha-pre /DQTDIR=C:\mixxx-buildserver\2.0-x64-release-minimal\build\qt-everywhere-opensource-src-4.8.6 /DWINLIB_PATH=C:\mixxx-buildserver\2.0-x64-release-minimal /Dx64=1 build\nsis\Mixxx.nsi
Command line defined: "PACKAGE_NAME=mixxx-2.1.0-alpha-pre-(no"
Processing config: C:\Program Files (x86)\NSIS\nsisconf.nsh
Can't open script "branch)-git6000-release-x64.exe"
scons: *** [win64_build\.foo] CalledProcessError : Command '"C:\Program Files (x86)\NSIS\makensis.exe" /DPACKAGE_NAME=mixxx-2.1.0-alpha-pre-(no branch)-git6000-release-x64.exe /DPRODUCT_VERSION=2.1.0-alpha-pre /DQTDIR=C:\mixxx-buildserver\2.0-x64-release-minimal\build\qt-everywhere-opensource-src-4.8.6 /DWINLIB_PATH=C:\mixxx-buildserver\2.0-x64-release-minimal /Dx64=1 build\nsis\Mixxx.nsi' returned non-zero exit status 1
Traceback (most recent call last):
  File "C:\Python27\scons-2.5.1\SCons\Action.py", line 1054, in execute
    result = self.execfunction(target=target, source=rsources, env=env)
  File "C:\projects\mixxx\src\SConscript", line 702, in BuildRelease
    subprocess.check_call(command)
  File "C:\Python27\lib\subprocess.py", line 541, in check_call
    raise CalledProcessError(retcode, cmd)
CalledProcessError: Command '"C:\Program Files (x86)\NSIS\makensis.exe" /DPACKAGE_NAME=mixxx-2.1.0-alpha-pre-(no branch)-git6000-release-x64.exe /DPRODUCT_VERSION=2.1.0-alpha-pre /DQTDIR=C:\mixxx-buildserver\2.0-x64-release-minimal\build\qt-everywhere-opensource-src-4.8.6 /DWINLIB_PATH=C:\mixxx-buildserver\2.0-x64-release-minimal /Dx64=1 build\nsis\Mixxx.nsi' returned non-zero exit status 1
scons: building terminated because of errors.

[Sébastien BLAISOT (sblaisot)]

To reproduce, simply clone the repo like this:

git checkout -f <commit_id>

this is what appveyor does to build a commit.

[Sébastien BLAISOT (sblaisot)]

https://github.com/mixxxdj/mixxx/pull/1046

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8698