tox ERROR: py27: nothing to do

[Ryan Beisner]

tox ERROR: nothing to do

All of the source (layer) OpenStack Charms are failing py27 in upstream gate tests. These charm unit tests are Python3-only, and should not have a py27 test declared in upstream project-config.

To illustrate, here is a batch of README changes, all failing on the non-existent py27 test:

https://review.openstack.org/#/q/topic:update-readme+owner:%22Ryan+Beisner%22+status:open

WIP project-config changes are here:

https://review.openstack.org/#/c/399299/

Example of tox output failure on py27:

2016-11-17 21:13:28.744743 | ERROR: Commands not specified. Please update relevant section of /home/jenkins/workspace/gate-charm-aodh-python27-ubuntu-xenial/tox.ini
2016-11-17 21:13:28.744826 | ___________________________________ summary ____________________________________
2016-11-17 21:13:28.744869 | ERROR: py27: nothing to do

[Ryan Beisner (1chb1n)]

Looking back, previous changes passed the missing py27 test. There must have been a behavior change in one of the test runners. I've not dug too deeply, as I agree with the current fail-when-missing behavior.

[Ryan Beisner (1chb1n)]

Triaged critical, as it's impossible to land code in these repos until resolved.

[Jeremy Stanley (fungi)]

This appears to be a behavior change in the tox 2.5 release from Wednesday.

[Jeremy Stanley (fungi)]

"2.5.0: slightly backward incompatible: fix issue310: the {posargs} substitution now properly preserves the tox command line positional arguments..." https://github.com/tox-dev/tox/blob/master/CHANGELOG

[Jeremy Stanley (fungi)]

Actually, no, it's "fix #316: Lack of commands key in ini file is now treated as an error" but I can't figure out what command should actually be set to in the [testenv] section to retain the proper behavior for built-in env names.

[Jeremy Stanley (fungi)]

I was able to solve this in the openstack-infra/gerritlib repo by copying the testenv.commands key from our openstack/cookiecutter tox.ini template: https://review.openstack.org/399795

[Ryan Beisner (1chb1n)]

Many thanks @fungi for the info.

Reference for future travelers:

https://github.com/tox-dev/tox/issues/316

https://github.com/tox-dev/tox/pull/407

https://github.com/tox-dev/tox/blob/1e888ce9b87d87045479ed4c320be803b05b0f38/CHANGELOG#L40

FWIW, with the affected subset of charm projects, we're not going to try to make py27 pass. Instead, we'll redefine the project-config for them so that py27 isn't attempted.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/403952

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/403953

[Ryan Beisner (1chb1n)]

Please see batch of changes:

https://review.openstack.org/#/q/topic:bug/1642981

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/403952
Committed: https://git.openstack.org/cgit/openstack/charm-neutron-api-odl/commit/?id=270f66adcd943921c4cbd6840f6a85e9d9fbb95a
Submitter: Jenkins
Branch: master

commit 270f66adcd943921c4cbd6840f6a85e9d9fbb95a
Author: Ryan Beisner <email address hidden>
Date: Mon Nov 28 18:21:14 2016 -0600

    Update tox.ini for py27 requirement

    Reactive source charms are Python3-only, but have py27 unit tests
    declared in project-config.

    The Tox tool recently changed behavior. It used to pass when a tox
    target was missing commands. Now it fails in that case.

    This commit places a py27 no-op shim to allow gate tests to pass,
    effectively restoring the original behavior for these py3x-only repos.

    Change-Id: I547c0ae0ac93fe7a9321a8d4d9a9711190dd5249
    Partial-Bug: 1642981

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/403953
Committed: https://git.openstack.org/cgit/openstack/charm-openvswitch-odl/commit/?id=57460f71ea7180870b3d23fc15e40cd18133e691
Submitter: Jenkins
Branch: master

commit 57460f71ea7180870b3d23fc15e40cd18133e691
Author: Ryan Beisner <email address hidden>
Date: Mon Nov 28 18:21:20 2016 -0600

    Update tox.ini for py27 requirement

    Reactive source charms are Python3-only, but have py27 unit tests
    declared in project-config.

    The Tox tool recently changed behavior. It used to pass when a tox
    target was missing commands. Now it fails in that case.

    This commit places a py27 no-op shim to allow gate tests to pass,
    effectively restoring the original behavior for these py3x-only repos.

    Change-Id: I3b53e36874805f453b29de28b76184aaf2da5c97
    Partial-Bug: 1642981