floating-ip nova notification is broken

Bug #1642918 reported by YAMAMOTO Takashi
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
YAMAMOTO Takashi

Bug Description

I1d7d4b80ee77deefce18df22f76cab81750c0397 seems to assume api resource names
matches with callbacks resource names.
unfortunately it isn't the case for floating-ip.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/399511

Changed in neutron:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
status: New → In Progress
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

It looks we have a coverage hole somewhere.

Changed in neutron:
importance: Undecided → High
tags: added: newton-backport-potential
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

Do you have a stacktrace?

Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/399724

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/399511
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=eef348f74a13f42780713aa9dfca9cc617fa52c8
Submitter: Jenkins
Branch: master

commit eef348f74a13f42780713aa9dfca9cc617fa52c8
Author: YAMAMOTO Takashi <email address hidden>
Date: Fri Nov 18 19:37:50 2016 +0900

    callbacks: Make the value of FLOATING_IP match with api resource

    Note: BEFORE_RESPONSE code assumes they match. Nova notifier uses
    FLOATING_IP/BEFORE_RESPONSE.

    Closes-Bug: #1642918
    Change-Id: If834ca1ee52d538cae4a5d164e0e0343c7019546

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/newton)

Reviewed: https://review.openstack.org/399724
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1529c039a0043884492a25321c9fbc25c0ef9847
Submitter: Jenkins
Branch: stable/newton

commit 1529c039a0043884492a25321c9fbc25c0ef9847
Author: YAMAMOTO Takashi <email address hidden>
Date: Fri Nov 18 19:37:50 2016 +0900

    callbacks: Make the value of FLOATING_IP match with api resource

    Note: BEFORE_RESPONSE code assumes they match. Nova notifier uses
    FLOATING_IP/BEFORE_RESPONSE.

    Closes-Bug: #1642918

    (cherry picked from commit eef348f74a13f42780713aa9dfca9cc617fa52c8)
    Change-Id: If834ca1ee52d538cae4a5d164e0e0343c7019546

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 10.0.0.0b2

This issue was fixed in the openstack/neutron 10.0.0.0b2 development milestone.

tags: added: neutron-proactive-backport-potential
tags: removed: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/422008

tags: removed: newton-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/mitaka)

Reviewed: https://review.openstack.org/422008
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=769502726f22fac151ebcf97c51423620e76b8df
Submitter: Jenkins
Branch: stable/mitaka

commit 769502726f22fac151ebcf97c51423620e76b8df
Author: YAMAMOTO Takashi <email address hidden>
Date: Fri Nov 18 19:37:50 2016 +0900

    callbacks: Make the value of FLOATING_IP match with api resource

    Note: BEFORE_RESPONSE code assumes they match. Nova notifier uses
    FLOATING_IP/BEFORE_RESPONSE.

    Conflicts:
     neutron/callbacks/resources.py

    Closes-Bug: #1642918
    Change-Id: If834ca1ee52d538cae4a5d164e0e0343c7019546
    (cherry picked from commit eef348f74a13f42780713aa9dfca9cc617fa52c8)

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 9.2.0

This issue was fixed in the openstack/neutron 9.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 8.4.0

This issue was fixed in the openstack/neutron 8.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.