Enable hacking rule extension H904 for Trove

[Amrith Kumar]

Currently, H904 is a hacking rule exception that is not enabled in Trove.

The work involved in fixing this bug is:

1. Wait till https://review.openstack.org/398935 Enable hacking extensions framework merges
2. Update tox.ini and enable H904 on the line that says "enable-extensions" in the [flake8] section
3. Run tox -e pep8 and find all the places where there are failures and fix them all.
4. Run unit tests and exercise the system.
5. Submit a change including the tox.ini change and all the changes once you get it all passing.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/398935
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=0a9b1e45fcf712dbe4ddff9d51d5b870bbc60d7d
Submitter: Jenkins
Branch: master

commit 0a9b1e45fcf712dbe4ddff9d51d5b870bbc60d7d
Author: Amrith Kumar <email address hidden>
Date: Thu Nov 17 06:11:39 2016 -0500

    Enable hacking extensions framework

    <long rant deleted>

    This change enables the hacking extensions ability in trove. That
    includes bumping the version of hacking that we use, and also adding
    the enable-extensions like in the [flake8] section. I've enabled two
    of the hacking extensions here.

    There are some limitations to the hacking rules that I've enabled so
    I'm also going to enter two bugs that others can fix (if they so
    desire).

    Change-Id: I6d8fc4bc03f948b84ad823e5248d78a4caa5c042
    Related-Bug: 1642554
    Related-Bug: 1642552

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/413852

[OpenStack Infra (hudson-openstack)]

Change abandoned by amrith (<email address hidden>) on branch: master
Review: https://review.openstack.org/413852
Reason: abandoned for inactivity. restore if you would like to continue to work on this

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/433681

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/433684

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/433782

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/433819

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/433833

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/433846

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/433858

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/434195

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/434315

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/434343

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/434438

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/433681
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=692938fbf6931d78ccb08adc18d22056e7bf5d96
Submitter: Jenkins
Branch: master

commit 692938fbf6931d78ccb08adc18d22056e7bf5d96
Author: Gábor Antal <email address hidden>
Date: Tue Feb 14 15:37:34 2017 +0100

    Handle log message interpolation by the logger in backup/

    According to OpenStack Guideline[1], logged string message should be
    interpolated by the logger.

    [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

    Change-Id: Ia79addd292000dfd1e3ecb15884b8dccac4d9284
    Related-Bug: #1642552

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/433684
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=945eecda3ef35f84c492e08056d032718aa48d11
Submitter: Jenkins
Branch: master

commit 945eecda3ef35f84c492e08056d032718aa48d11
Author: Gábor Antal <email address hidden>
Date: Tue Feb 14 15:49:17 2017 +0100

    Handle log message interpolation by the logger in cluster/

    According to OpenStack Guideline[1], logged string message should be
    interpolated by the logger.

    [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

    Change-Id: Id67c1599d7921247521d4b9e65222a670220a801
    Related-Bug: #1642552

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/433782
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=be5732345c4c6870837a554c96e4201b5635fb56
Submitter: Jenkins
Branch: master

commit be5732345c4c6870837a554c96e4201b5635fb56
Author: Gábor Antal <email address hidden>
Date: Tue Feb 14 18:03:38 2017 +0100

    Handle log message interpolation by the logger in common/strategies/

    According to OpenStack Guideline[1], logged string message should be
    interpolated by the logger.

    [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

    Change-Id: I4a900a56947eae9668f3af9c7374777621dcc76a
    Related-Bug: #1642552

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/433833
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=7191530abb7a21542da56427ec638a3a1fa1b602
Submitter: Jenkins
Branch: master

commit 7191530abb7a21542da56427ec638a3a1fa1b602
Author: Gábor Antal <email address hidden>
Date: Tue Feb 14 18:54:43 2017 +0100

    Handle log message interpolation by the logger part 5

    The following directories were checked in this commit:
      - conductor/
      - configuration/

    According to OpenStack Guideline[1], logged string message should be
    interpolated by the logger.

    [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

    Change-Id: Ib46b6a5c947e250ec549ed9be1b8a7862f528d52
    Related-Bug: #1642552

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/433846
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=0956c1e13441902a5369287374e7f84ed73a460a
Submitter: Jenkins
Branch: master

commit 0956c1e13441902a5369287374e7f84ed73a460a
Author: Gábor Antal <email address hidden>
Date: Tue Feb 14 19:21:24 2017 +0100

    Handle log message interpolation by the logger part 6

    The following directories were fixed in this commit:
      - datastore/
      - db/
      - dns/
      - instance/

    According to OpenStack Guideline[1], logged string message should be
    interpolated by the logger.

    [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

    Change-Id: Idd22bd5b561198eb02a03383d0ef53bd900bdcf9
    Related-Bug: #1642552

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/433858
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=861557cebd67609f6ec59d085e5213ae76652afb
Submitter: Jenkins
Branch: master

commit 861557cebd67609f6ec59d085e5213ae76652afb
Author: Gábor Antal <email address hidden>
Date: Tue Feb 14 19:54:27 2017 +0100

    Handle log message interpolation by the logger part 7

    The following directories were fixed in this commit:
      - extensions/

    According to OpenStack Guideline[1], logged string message should be
    interpolated by the logger.

    [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

    Change-Id: I47b7215cd0b61c52405917ecde849a3ea1ae5e32
    Related-Bug: #1642552

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/434438
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=95732bb08fe4b825b799ce82ebd5fa28d117a95b
Submitter: Jenkins
Branch: master

commit 95732bb08fe4b825b799ce82ebd5fa28d117a95b
Author: Gábor Antal <email address hidden>
Date: Wed Feb 15 19:02:43 2017 +0100

    Handle log message interpolation by the logger part 11

    The following directories were fixed in this commit:
      - tests (and all the subdirectories)

    According to OpenStack Guideline[1], logged string message should be
    interpolated by the logger.

    [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

    Change-Id: I26ccd7587fcda2948772cb829ce4b20b38f1c792
    Related-Bug: #1642552

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/434315
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=1419875066749c797c9a39fd9bda6c2afe3c4235
Submitter: Jenkins
Branch: master

commit 1419875066749c797c9a39fd9bda6c2afe3c4235
Author: Gábor Antal <email address hidden>
Date: Wed Feb 15 15:25:47 2017 +0100

    Handle log message interpolation by the logger part 9

    The following directories were fixed in this commit:
      - guestagent/backup
      - guestagent/datastore

    According to OpenStack Guideline[1], logged string message should be
    interpolated by the logger.

    [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

    Change-Id: I437ffa2d3d6f756c6af1f6b94781b3f03a83814f
    Related-Bug: #1642552

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/434343
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=219d8f9dc4af52dafaf38d769c70a3d7ebbc9022
Submitter: Jenkins
Branch: master

commit 219d8f9dc4af52dafaf38d769c70a3d7ebbc9022
Author: Gábor Antal <email address hidden>
Date: Wed Feb 15 16:22:43 2017 +0100

    Handle log message interpolation by the logger part 10

    The following directories were fixed in this commit:
      - module/
      - quota/
      - taskmanager/

    According to OpenStack Guideline[1], logged string message should be
    interpolated by the logger.

    [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

    Change-Id: Iabfb6e8caeae3afe057b77315f26f9fdcaffda54
    Related-Bug: #1642552

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/434195
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=a9c8ffa8cee562ae60c37df6ae58f9d435c98e94
Submitter: Jenkins
Branch: master

commit a9c8ffa8cee562ae60c37df6ae58f9d435c98e94
Author: Gábor Antal <email address hidden>
Date: Wed Feb 15 11:13:53 2017 +0100

    Handle log message interpolation by the logger part 8

    The following directories were fixed in this commit:
      - guestagent/ (not including subdirectories)
      - guestagent/module/
      - guestagent/strategies/

    According to OpenStack Guideline[1], logged string message should be
    interpolated by the logger.

    [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

    Change-Id: Ia16aca6d08524f810131c8401ea736c190f396eb
    Related-Bug: #1642552

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/433819
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=ded64b45c6db4e22d27aa66a7cfcd5784a771a1d
Submitter: Jenkins
Branch: master

commit ded64b45c6db4e22d27aa66a7cfcd5784a771a1d
Author: Gábor Antal <email address hidden>
Date: Tue Feb 14 18:43:05 2017 +0100

    Handle log message interpolation by the logger in common/

    According to OpenStack Guideline[1], logged string message should be
    interpolated by the logger.

    [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

    Change-Id: I946422e662b5efc453bfe76f3631ece1716dbb4c
    Related-Bug: #1642552

[OpenStack Infra (hudson-openstack)]

Change abandoned by Samuel Matzek (<email address hidden>) on branch: master
Review: https://review.openstack.org/439377
Reason: Abandoning this change because it has been in merge conflict for 5 months without update.