IPs with multiple names can corrupt DNS zone data
Bug #1642033 reported by
LaMont Jones
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Critical
|
LaMont Jones | ||
2.1 |
Fix Released
|
Critical
|
LaMont Jones |
Bug Description
If the same IP address is assigned to names in multiple domains, then the zone data gets corrupted.
If the name is the top of a domain, then the zone file is illegally formatted and fails to load as a result.
Related branches
lp:~lamont/maas/bug-1642033
- Mike Pontillo (community): Approve
- Gavin Panella (community): Approve
-
Diff: 499 lines (+297/-65)3 files modifiedsrc/maasserver/models/staticipaddress.py (+157/-63)
src/maasserver/models/tests/test_staticipaddress.py (+139/-2)
src/maasserver/websockets/handlers/tests/test_domain.py (+1/-0)
lp:~lamont/maas/bug-1642033-2.1
- LaMont Jones (community): Approve
-
Diff: 512 lines (+299/-65)4 files modifieddocs/changelog.rst (+2/-0)
src/maasserver/models/staticipaddress.py (+157/-63)
src/maasserver/models/tests/test_staticipaddress.py (+139/-2)
src/maasserver/websockets/handlers/tests/test_domain.py (+1/-0)
no longer affects: | maas/2.0 |
Changed in maas: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
If you wish to reproduce this:
maas $SESSION domains create foo.example.com example. com ip_addressess= 1.1.1.1 example. com ip_addressess= 1.1.1.1
maas $SESSION domains create bar.example.com
maas $SESSION dnsresources create fqdn=foo.
maas $SESSION dnsresources create fqdn=bar.
Note the errors in /var/log/syslog: maas/zone. foo.example. com:23: ignoring out-of-zone data (\@) maas/zone. foo.example. com:23: \@: bad owner name (check-names) maas/zone. foo.example. com failed: bad owner name (check-names)
Nov 15 09:43:56 kohlrabi named[10335]: /etc/bind/
Nov 15 09:43:56 kohlrabi named[10335]: /etc/bind/
Nov 15 09:43:56 kohlrabi named[10335]: zone foo.example.com/IN: loading from master file /etc/bind/
Nov 15 09:43:56 kohlrabi named[10335]: zone foo.example.com/IN: not loaded due to errors.
...