show-status-log noise reduction buggy

Bug #1642031 reported by Adam Collard
24
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
High
Tim Penhey

Bug Description

$ juju-2.0 version
2.0.1-xenial-amd64

In what I assume is a fix for bug 1530840, juju's show-status-log (nee status-history) has an attempt at de-duplicating repeated status updates.

It has a number of problems

1) the de-duplication seems to happen after filtering for number of updates e.g.

$ juju-2.0 show-status-log keystone/0 -n 10
TIME TYPE STATUS MESSAGE
15 Nov 2016 19:10:50Z juju-unit idle
15 Nov 2016 19:15:21Z juju-unit executing running update-status hook
15 Nov 2016 19:15:37Z workload active Unit is ready
15 Nov 2016 19:28:49Z idle last 3 statuses repeated 2 times

Wait, where are my 10 updates? Oh it's 3 + (3 * 2) + 1... not what I wanted

2) the fake entry for the repeated message has a bogus time e.g.

15 Nov 2016 16:52:31Z workload waiting Incomplete relations: database
15 Nov 2016 19:18:22Z idle last 1 statuses repeated 1 times
15 Nov 2016 16:53:31Z juju-unit executing running identity-service-relation-changed hook

Wait, 16:52 -> 19:18 -> 16:53?

3) idle as a STATUS seems weird/buggy (hopefully clear from previous 2 examples)

Tags: landscape
Ian Booth (wallyworld)
Changed in juju:
milestone: none → 2.1.0-beta1
assignee: nobody → Horacio Durán (hduran-8)
importance: Undecided → High
status: New → Triaged
Curtis Hovey (sinzui)
Changed in juju:
milestone: 2.1-beta1 → 2.1-beta2
Curtis Hovey (sinzui)
Changed in juju:
milestone: 2.1-beta2 → none
Curtis Hovey (sinzui)
Changed in juju:
milestone: none → 2.1-rc1
Changed in juju:
milestone: 2.1-beta4 → 2.2.0-alpha1
Changed in juju:
milestone: 2.2-alpha1 → none
Changed in juju:
assignee: Horacio Durán (hduran-8) → John A Meinel (jameinel)
Revision history for this message
Tim Penhey (thumper) wrote :

I have also found this during recent testing.

Changed in juju:
milestone: none → 2.3.1
assignee: John A Meinel (jameinel) → nobody
Tim Penhey (thumper)
Changed in juju:
assignee: nobody → Tim Penhey (thumper)
status: Triaged → In Progress
Revision history for this message
John A Meinel (jameinel) wrote :
John A Meinel (jameinel)
Changed in juju:
status: In Progress → Fix Committed
milestone: 2.3.1 → 2.3-rc2
Changed in juju:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.