Webstaff work log stores unnecessary data

[Bill Erickson]

Evergreen 2.11 -- affects all versions

The browser client work log service stores concise user, item, hold, action, timing data to track log entries. In addition, the full fleshed transaction response blob is stored. This extra blob serves no purpose and takes up a lot of space in localStorage and/or Hatch.

Patch to avoid storing the extra data en route.

[Bill Erickson (berick)]

Fix pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1641708-webstaff-worklog-lean-data

[Bill Erickson (berick)]

To test:

1. Perorm checkouts and other log-tracked actions in the client.

2. Open Administration -> Workstation -> Stored Preferences and see values for key "eg.patron_log".

3. Values added after the patch will only contain ~8 keys with string values, no large nested objects.

[Galen Charlton (gmc)]

Well, /eg/staff/admin/workstation/log currently references the 'data' key in work and patron log entries to do things like get the patron or copy ID in order to allow the user to open the related record, so the current patch breaks functionality. I've removed the pullrequest tag for now.

That said, I agree with the ultimate aim of the patch. Various related record IDs for each action type are already split out into separate keys in the work log entries; they just need to be used by admin/workstation/log.

[Bill Erickson (berick)]

Good catch, Galen. Thanks for reviewing.

I have force-pushed a squashed commit back to the same branch that avoids the use of 'entry.data' in the work log UI. In one case (patron_id) it was simply a case of removing ".data." from the path. For "hold_id", I also added the value to the entry at the source (egWorkLog), because it only existing in .data.

I confirmed that patron and holds now display as expected in the work log.

Slapping the pullrequest back on.

[Bill Erickson (berick)]

Also, since this change is not compatible with existing work log data, I'm removing the back-port targets.

[Galen Charlton (gmc)]

I've pushed a signoff + a follow-up that records the hold ID only for requested_hold actions to user/gmcharlt/lp1641708_signoff.

[Kathy Lussier (klussier)]

Thank you Bill and Galen! Merged to master and release 2.12.