SMLite:R3.0.2.x Build 11: Provisioning does not start with Exception('Both internal and external vips need to be configured',)" }

[sundarkh]

SMLite:R3.0.2.x Build 11: Provisioning does not start with Exception('Both internal and external vips need to be configured',)"

1) This is Multi Interface Open stack HA setup, using the following testbed.py
https://github.com/Juniper/contrail-tools/blob/master/testbeds/testbed_smgr_multi_node.py.ubuntu-14.04

host1 = 'root@10.204.217.13'
host2 = 'root@10.204.217.77'
host3 = 'root@10.204.217.176'
host4 = 'root@10.204.217.129'
host5 = 'root@10.204.217.131'
host6 = 'root@10.204.217.132'

env.roledefs = {

    'all': [host1, host2, host3, host4, host5, host6],
    'cfgm': [host1, host2, host3],
    'openstack': [host1, host2, host3],
    'control': [host1, host2, host3],
    'compute': [host4, host5, host6],
    'collector': [host1, host2, host3],
    'webui': [host1, host2, host3],
    'database': [host1, host2, host3],
    'build': [host_build],

}

env.hostnames ={
    'all': ['nodec28', 'nodeg37', 'nodec10', 'nodei17', 'nodei19', 'nodei20']
}

2) Install SM Lite R3.0.2.x build 11. Inititate Provisioning , it does not get started with error

----> Provisioning the cluster
{
    "return_code": 9,
    "return_data": null,
    "return_msg": "Exception('Both internal and external vips need to be configured',)"
}

Trace:
------

"2016-11-14 02:42:55,507-ERROR-server_mgr_main.py:3166-log_trace(): Traceback (most recent call last):
"
"2016-11-14 02:42:55,507-ERROR-server_mgr_main.py:3166-log_trace(): File "/opt/contrail/server_manager/server_mgr_main.py", line 4001, in provision_server
    self._smgr_validations.validate_vips(cluster_id, self._serverDb)
"
"2016-11-14 02:42:55,508-ERROR-server_mgr_main.py:3166-log_trace(): File "/opt/contrail/server_manager/server_mgr_validations.py", line 307, in validate_vips
    raise e
"
"2016-11-14 02:42:55,509-ERROR-server_mgr_main.py:3166-log_trace(): Exception: Both internal and external vips need to be configured
"

Notes :

R3.1.1 Build 36, Mitaka SMLite provisioning has worked, in the same Multi Interface Open stack HA
setup and it does not face the issue mentioned here,

though the server_mgr_main code to handle is same

[Abhay Joshi (abhayj)]

Sundar,

Did this work before in earlier 3.0.2.x builds (build 10 or earlier) or this is first time you are trying 3.0.2.x?

[sundarkh (sundar-kh)]

Earlier in build 8, SM lite provisioning worked fine on a setup which had Openstack HA

The issue reported here is tested over , Multi Interface + Openstack HA as mentioned in the testbed.py shared , and 3.0.2.x build tried for the first time

[Nitish Krishna Kaveri (nitishk)]

This bug occurs because of the following reason:

In 3.0.2.x SM Lite the testbed.py is converted to old params format. Over here the external VIP is correctly identified as missing. This means you need to pass external vip for multi IF testbeds (regardless of SM version/SM lite version).

In 3.0.2.x SM the cluster JSON passed was in new params. In this case, the validation did not happen at all, because of which the provision was allowed to go thru. This behavior is wrong but doesn't need a code change, it is just the json that needs to be changed (either give external vip in old params format or in new params format). We do not officially support new params in 3.0 and because this issue is a bug only for new params format JSON given to SM I am marking this bug as Invalid.

I will file a separate bug to fix this validation being wrong for New params in 3.1 branches and above.

[Ritam Gangopadhyay (ritam)]

The validation code in function validate_multi_interface_vip() of server_mgr_validations.py should not make it mandatory to specify external vip. A contrail cluster can be deployed without an external vip on multi interface setup. There would be no option of load balancing for an external process trying to reach the server in such deployment but that doesn't make it un-usable or non-deploy able.

So the code path for both SM and SMLite should accept only internal_vip being configured from the control-data network subnet and not make it mandatory to specify an external_vip from management n/w subnet in case of multi interface setup. This flexibility is already available on fab and it does not impose any such restriction.

[Abhay Joshi (abhayj)]

Not having external_VIP makes the configuration unusable. Of course it will work all the servers are up and running. The point of HA is to provide guard agaist failures. Since there is internal VIP specified, it shows intent to have HA. Does not make sense to have it for internal, but not for external.

The configuration is indeed invalid.

[Ritam Gangopadhyay (ritam)]

This should be included in the server manager documentation that behavior between fab and SM is different. And its mandatory in SM and SMLite to specify external_vip for a multi interface setup. Moreover SM UI should also make it mandatory to specify external_vip.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/26171
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/26172
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/26173
Submitter: Nitish Krishna Kaveri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/26171
Committed: http://github.org/Juniper/contrail-server-manager/commit/02f314378f42f64209f85816533f6c3deeb784c0
Submitter: Zuul
Branch: master

commit 02f314378f42f64209f85816533f6c3deeb784c0
Author: nitishkrishna <email address hidden>
Date: Wed Nov 16 11:38:20 2016 -0800

Closes-Bug: #1641587 - SM Provision vip validations was using old params format

The vip params were being sourced from old format, this has been changed to new format.
Will be cherry picked to 3.1 and 3.2 only

Change-Id: Id5ce8d5a7b0bea667b525c2a5d396f1b7a78d0b7

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/26173
Committed: http://github.org/Juniper/contrail-server-manager/commit/d01e172d3ad6b602e1c4c33398a0d45bc3c3db62
Submitter: Zuul
Branch: R3.2

commit d01e172d3ad6b602e1c4c33398a0d45bc3c3db62
Author: nitishkrishna <email address hidden>
Date: Wed Nov 16 11:38:20 2016 -0800

Closes-Bug: #1641587 - SM Provision vip validations was using old params format

The vip params were being sourced from old format, this has been changed to new format.
Will be cherry picked to 3.1 and 3.2 only

Change-Id: Id5ce8d5a7b0bea667b525c2a5d396f1b7a78d0b7

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/26172
Committed: http://github.org/Juniper/contrail-server-manager/commit/63fc282d4f329d4f25eecc0f550fd2e37db4137a
Submitter: Zuul
Branch: R3.1

commit 63fc282d4f329d4f25eecc0f550fd2e37db4137a
Author: nitishkrishna <email address hidden>
Date: Wed Nov 16 11:38:20 2016 -0800

Closes-Bug: #1641587 - SM Provision vip validations was using old params format

The vip params were being sourced from old format, this has been changed to new format.
Will be cherry picked to 3.1 and 3.2 only

Change-Id: Id5ce8d5a7b0bea667b525c2a5d396f1b7a78d0b7