find in page doesn’t wrap correctly
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Oxide |
Fix Released
|
Medium
|
Olivier Tilloy | ||
1.19 |
Fix Released
|
Medium
|
Olivier Tilloy |
Bug Description
I’m testing webbrowser-app with a local build of oxide master, and I’m seeing a regression in the find-in-page functionality.
1) If I browse to e.g. http://
2) If I press the next match button, the second match is highlighted (counter: "2/3")
3) If I press again the next match button, the third match is highlighted (counter: "3/3")
4) If I press again the next match button, I expect the navigation to wrap, and the first match to be highlighted, but instead no match is highlighted, and the counter remains at "3/3"
5) If I press again the next match button, the first match is highlighted, and the counter updated to "1/3".
It looks like find-in-page behaves as if there was a fourth phantom match that doesn’t update the counter (at step 4).
I’m not observing this with oxide 1.18.3, so this seems to be a recent regression in oxide master.
Related branches
- Chris Coulson: Approve
-
Diff: 111 lines (+17/-11)3 files modifiedqt/tests/qmltests/api/tst_WebView_findController.qml (+8/-2)
shared/browser/oxide_find_controller.cc (+7/-7)
shared/browser/oxide_find_controller.h (+2/-2)
Changed in oxide: | |
status: | New → Triaged |
importance: | Undecided → Medium |
milestone: | none → branch-1.20 |
assignee: | nobody → Chris Coulson (chrisccoulson) |
Changed in oxide: | |
status: | Triaged → In Progress |
Changed in oxide: | |
assignee: | Chris Coulson (chrisccoulson) → Olivier Tilloy (osomon) |
Changed in oxide: | |
status: | In Progress → Fix Released |