Prevent the deploy workflow doing anything if the Heat stack is in (CREATE|UPDATE)_IN_PROGRESS

Bug #1640249 reported by Dougal Matthews
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Dougal Matthews

Bug Description

Doing this would prevent any changes to the plan that would then not be deployed. We can do this by adding a workflow task that verifies the stack status.

We should also consider doing this with the other workflows that touch heat. i.e. node delete.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/396567

Changed in tripleo:
status: Confirmed → In Progress
Steven Hardy (shardy)
Changed in tripleo:
milestone: ocata-1 → ocata-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/398959

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/398959
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=7f16d103560bf6d915ac717e9d5b092295bc0eae
Submitter: Jenkins
Branch: master

commit 7f16d103560bf6d915ac717e9d5b092295bc0eae
Author: Dougal Matthews <email address hidden>
Date: Thu Nov 17 11:43:36 2016 +0000

    Only start the deploy if the Heat stack isn't already in progress

    At the moment the deploy command will take a number of steps, including
    updating the plan and setting parameters in Mistral. Then when it gets
    to the deploy, the workflow will fail. This change stops it earlier in
    the process, which will be quicker and cleaner.

    Change-Id: I09e40e3f27b9ba3b0f3dad97cece6afbe28bd6b9
    Partial-Bug: #1640249

Changed in tripleo:
milestone: ocata-2 → ocata-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/396567
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=afdf3e94554da5fe241256c7ffdf71a4b8eec336
Submitter: Jenkins
Branch: master

commit afdf3e94554da5fe241256c7ffdf71a4b8eec336
Author: Dougal Matthews <email address hidden>
Date: Fri Nov 11 09:56:36 2016 +0000

    Only start the deploy if the Heat stack isn't already in progress

    Closes-Bug: #1640249
    Change-Id: I03a2945e39ba9d6bb3067483acbc746149a3991b

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 5.8.0

This issue was fixed in the openstack/tripleo-common 5.8.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.