openstack overcloud node delete doesn't require --stack but also doesn't default to overcloud

[Dougal Matthews]

The command should either default the value to "overcloud" (as we do in other places) or it should require that the user provides it.

At the moment it will fail as it can't find the stack "None" with a confusing error.

The third option would be to give a better error and don't start the workflow with a None stack.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/395522

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/395522
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=0af664656d82ab5d658228cd078691f9abc3e789
Submitter: Jenkins
Branch: master

commit 0af664656d82ab5d658228cd078691f9abc3e789
Author: Dougal Matthews <email address hidden>
Date: Wed Nov 9 10:49:47 2016 +0000

    Default the stack name to 'overcloud' in overcloud node delete

    The stack needs to be passed as either a CLI arg with --stack or via the
    environment variable OVERCLOUD_STACK_NAME. At the moment if it isn't
    provided either way the workflow is called with an empty string for the
    stack name. This will then fail.

    This change defaults the stack name to 'overcloud' which matches the
    deploy command. One of the unit tests was updated so that it didn't pass
    the default value to ensure that it can still be overwritten.

    Change-Id: Ie44d5cba90e81ae1a35a4cabc6e20a202bfddef0
    Closes-Bug: #1640244
    Partial-Bug: #1640770

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 5.5.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/404324

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/404324
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=2ed71e8e857bd69100d12c9ac67dd034b6c3d3f1
Submitter: Jenkins
Branch: stable/newton

commit 2ed71e8e857bd69100d12c9ac67dd034b6c3d3f1
Author: Dougal Matthews <email address hidden>
Date: Wed Nov 9 10:49:47 2016 +0000

    Default the stack name to 'overcloud' in overcloud node delete

    The stack needs to be passed as either a CLI arg with --stack or via the
    environment variable OVERCLOUD_STACK_NAME. At the moment if it isn't
    provided either way the workflow is called with an empty string for the
    stack name. This will then fail.

    This change defaults the stack name to 'overcloud' which matches the
    deploy command. One of the unit tests was updated so that it didn't pass
    the default value to ensure that it can still be overwritten.

    Change-Id: Ie44d5cba90e81ae1a35a4cabc6e20a202bfddef0
    Closes-Bug: #1640244
    Partial-Bug: #1640770
    (cherry picked from commit 0af664656d82ab5d658228cd078691f9abc3e789)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 5.4.1 release.