Fuel erases first 10 megabytes of every disk mounted to fuel nodes

[Eugene Nikanorov]

Related issue: https://bugs.launchpad.net/fuel/+bug/1529691
Fuel should not attempt to erase every disk on the host.

In cases when external volumes are mounted as iscsi/fibrechannel devices on computes fuel will erase first ten megabytes of them too, e.g. not only corrupting the cloud, but also end user's data.

[Dmitry Guryanov (dguryanov)]

Already fixed by https://github.com/openstack/fuel-astute/commit/e770d4ec7d302e958ffae8db87e633e9d5e3db91

[Eugene Nikanorov (enikanorov)]

Was it backported to 8.0? 7.0?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/426740

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/426764

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/426764
Committed: https://git.openstack.org/cgit/openstack/fuel-astute/commit/?id=77f1015b3ec2bb192ebd20a95dfbbdd00e4f29c5
Submitter: Jenkins
Branch: stable/7.0

commit 77f1015b3ec2bb192ebd20a95dfbbdd00e4f29c5
Author: Dmitry Guryanov <email address hidden>
Date: Fri Mar 25 16:19:29 2016 +0300

    Erase only boot code in MBR during node delete

    Zeroing first 1Mb of a block device will almost always
    lead to serios system error, if there is a filesystem
    on this block device and this filesystem is mounted.

    This code had 2 points: to prevent system from booting
    from hard drive after reboot and to prevent anaconda
    (or other OS installer) to automatically recognize
    disk structure. But since we only use image-based provision
    this is not the case anymore.

    It's enough to clear first 446 bytes of MBR where the first
    stage of a bootloader resides. So we will also be able to
    check nodes disks and filesystems after deleting it from
    cluster for troubleshooting for example, because partition
    scheme will not be touched.

    https://wiki.archlinux.org/index.php/Master_Boot_Record

    Change-Id: I60f2b250d6d5997b4b471c27ed00d057ae73c30a
    Fixes-bug: #1538587
    Fixes-bug: #1640014
    (cherry picked from commit e770d4ec7d302e958ffae8db87e633e9d5e3db91)

[TatyanaGladysheva (tgladysheva)]

Verified on MOS 7.0 + MU7 updates.

Steps to verify:
1. Deploy cluster and then reset it
2. Check messages in astute.log which appeared after resetting

Actual results:
From astute.log: http://paste.openstack.org/show/599780/
There are messages like 'erasing bootstrap code area in MBR of vda'.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/426740
Committed: https://git.openstack.org/cgit/openstack/fuel-astute/commit/?id=9edd8a95767f5cf36e151aaf487405d7e66c4512
Submitter: Jenkins
Branch: stable/8.0

commit 9edd8a95767f5cf36e151aaf487405d7e66c4512
Author: Dmitry Guryanov <email address hidden>
Date: Fri Mar 25 16:19:29 2016 +0300

    Erase only boot code in MBR during node delete

    Zeroing first 1Mb of a block device will almost always
    lead to serios system error, if there is a filesystem
    on this block device and this filesystem is mounted.

    This code had 2 points: to prevent system from booting
    from hard drive after reboot and to prevent anaconda
    (or other OS installer) to automatically recognize
    disk structure. But since we only use image-based provision
    this is not the case anymore.

    It's enough to clear first 446 bytes of MBR where the first
    stage of a bootloader resides. So we will also be able to
    check nodes disks and filesystems after deleting it from
    cluster for troubleshooting for example, because partition
    scheme will not be touched.

    https://wiki.archlinux.org/index.php/Master_Boot_Record

    Change-Id: I60f2b250d6d5997b4b471c27ed00d057ae73c30a
    Fixes-bug: #1538587
    Fixes-bug: #1640014
    (cherry picked from commit e770d4ec7d302e958ffae8db87e633e9d5e3db91)

[TatyanaGladysheva (tgladysheva)]

Verified on MOS 8.0 + MU4 updates.

Steps to verify:
1. Deploy cluster and then reset it
2. Check messages in astute.log which appeared after resetting

Actual results:
From astute.log: http://paste.openstack.org/show/605025/
There are messages like 'erasing bootstrap code area in MBR of vda'.