Invalid flow-rate exported from Vrouter UVE

Bug #1639698 reported by Ashok Singh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.0
Fix Committed
Medium
Ashok Singh
R3.0.2.x
Fix Committed
Medium
Ashok Singh
R3.0.3.x
Fix Committed
Medium
Ashok Singh
R3.1
Fix Committed
Medium
Ashok Singh
R3.2
Fix Committed
Medium
Ashok Singh
Trunk
Fix Committed
Medium
Ashok Singh

Bug Description

The flow-rate field has max_flow_adds_per_second, min_flow_adds_per_second, max_flow_deletes_per_second and min_flow_deletes_per_second as members. The initial values for these members are set as 0xffffffff and also the values for these fields are set as 0xffffffff after they are used for export. During export of Vrouter UVE(which is done periodically) if these fields have not been set, it is possible we end up exporting 0xffffffff as value of these fields.

Tags: vrouter
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/25766
Submitter: Ashok Singh (<email address hidden>)

Jeba Paulaiyan (jebap)
Changed in juniperopenstack:
importance: Undecided → Medium
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/26202
Submitter: Ashok Singh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.2

Review in progress for https://review.opencontrail.org/26216
Submitter: Ashok Singh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/26217
Submitter: Ashok Singh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/25766
Submitter: Ashok Singh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0.3.x

Review in progress for https://review.opencontrail.org/26218
Submitter: Ashok Singh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0.2.x

Review in progress for https://review.opencontrail.org/26219
Submitter: Ashok Singh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/26202
Committed: http://github.org/Juniper/contrail-controller/commit/1fb7f31a895b63e89a552f3403370c4d67ca0d3f
Submitter: Zuul
Branch: master

commit 1fb7f31a895b63e89a552f3403370c4d67ca0d3f
Author: ashoksingh <email address hidden>
Date: Thu Nov 17 12:16:23 2016 +0530

Fix Invalid flow-rate exported from Vrouter UVE

When flow added/deleted per second is exported, we should export flow
created/deleted from same time slot.
Closes-Bug: #1639698

Change-Id: I32f07b1c8221c3cbd7007c265809cf1fecaded9a

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/26216
Committed: http://github.org/Juniper/contrail-controller/commit/eb0faa6aeca924e0361236ec85529f14912a4658
Submitter: Zuul
Branch: R3.2

commit eb0faa6aeca924e0361236ec85529f14912a4658
Author: ashoksingh <email address hidden>
Date: Thu Nov 17 12:16:23 2016 +0530

Fix Invalid flow-rate exported from Vrouter UVE

When flow added/deleted per second is exported, we should export flow
created/deleted from same time slot.
Closes-Bug: #1639698

(cherry picked from commit 1fb7f31a895b63e89a552f3403370c4d67ca0d3f)

Change-Id: I4d09a87f706388785b8fb3fa7979b375af1a7b04

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/26217
Committed: http://github.org/Juniper/contrail-controller/commit/08fd760af4410e7e8f56dc0d9a8f4fc5d3d3f009
Submitter: Zuul
Branch: R3.1

commit 08fd760af4410e7e8f56dc0d9a8f4fc5d3d3f009
Author: ashoksingh <email address hidden>
Date: Thu Nov 17 12:16:23 2016 +0530

Fix Invalid flow-rate exported from Vrouter UVE

When flow added/deleted per second is exported, we should export flow
created/deleted from same time slot.
Closes-Bug: #1639698

(cherry picked from commit 1fb7f31a895b63e89a552f3403370c4d67ca0d3f)

Change-Id: Ic077929a1908dab21f8e877d329ff46e8443c6d9

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/25766
Committed: http://github.org/Juniper/contrail-controller/commit/4c00bbef8526b364d0c8ae576a986bf5055716eb
Submitter: Zuul
Branch: R3.0

commit 4c00bbef8526b364d0c8ae576a986bf5055716eb
Author: ashoksingh <email address hidden>
Date: Thu Nov 17 13:51:09 2016 +0530

Fix Invalid flow-rate exported from Vrouter UVE

Currently flow-rate is updated in Agent::FlowEvent task while it is being read in Agent::Uve task and there is no exclusion between these tasks. Made changes to update flow-rate in a new task which has exclusion with Agent::Uve. Also ensured in Agent::Uve task that flow-rate
is not exported if it is not yet computed.

Change-Id: I19bff570b0990a3b932576bf23c4b13a8260a3a6
Closes-Bug: #1639698

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/26219
Committed: http://github.org/Juniper/contrail-controller/commit/9124c98fb04e899402c03882dd45aba22d46aa60
Submitter: Zuul
Branch: R3.0.2.x

commit 9124c98fb04e899402c03882dd45aba22d46aa60
Author: ashoksingh <email address hidden>
Date: Thu Nov 17 13:51:09 2016 +0530

Fix Invalid flow-rate exported from Vrouter UVE

Currently flow-rate is updated in Agent::FlowEvent task while it is being read in Agent::Uve task and there is no exclusion between these tasks. Made changes to update flow-rate in a new task which has exclusion with Agent::Uve. Also ensured in Agent::Uve task that flow-rate
is not exported if it is not yet computed.

Closes-Bug: #1639698
(cherry picked from commit 4c00bbef8526b364d0c8ae576a986bf5055716eb)

Change-Id: I7073efbe0b92753310b3e41771c2660784d9bdc2

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/26218
Committed: http://github.org/Juniper/contrail-controller/commit/2b59e3fbd5e77650d3706de09ec870f167e5c8ee
Submitter: Zuul
Branch: R3.0.3.x

commit 2b59e3fbd5e77650d3706de09ec870f167e5c8ee
Author: ashoksingh <email address hidden>
Date: Thu Nov 17 13:51:09 2016 +0530

Fix Invalid flow-rate exported from Vrouter UVE

Currently flow-rate is updated in Agent::FlowEvent task while it is being read in Agent::Uve task and there is no exclusion between these tasks. Made changes to update flow-rate in a new task which has exclusion with Agent::Uve. Also ensured in Agent::Uve task that flow-rate
is not exported if it is not yet computed.

Closes-Bug: #1639698
(cherry picked from commit 4c00bbef8526b364d0c8ae576a986bf5055716eb)

Change-Id: I18df886d1b0d5a23723a9f2742ca6b1049a7ba1e

information type: Proprietary → Public
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.