DHCP agent notifying all ports ready on sync state

Bug #1639086 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Kevin Benton

Bug Description

The DHCP agent is notifying the server every port is ready that it serves after running the sync_state command, even if it's only for one network. This is an expensive waste of resources because the DHCP agent might resync one network and then have to notify the server of thousands of ports.

Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
Changed in neutron:
status: New → In Progress
tags: added: newton-backport-potential
Changed in neutron:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/379270
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7dc2707c2b0b05ad7699a24680a5b45e67f717fc
Submitter: Jenkins
Branch: master

commit 7dc2707c2b0b05ad7699a24680a5b45e67f717fc
Author: Kevin Benton <email address hidden>
Date: Thu Sep 29 01:37:59 2016 -0700

    Only mark ports ready on synced networks

    The DHCP agent was previously resending every single port to
    the server whenever sync_state was called, even if it was just
    for one network.

    This let to sending way too much unnecessary data to the server
    and also potentially resulted in sending a port to the server
    that wasn't actually provisioned yet.

    This patch corrects the behavior by only sending ports for networks
    that are being synced if it's a conditional sync.

    Closes-Bug: #1639086
    Change-Id: Ie7686837b18ff251baa315ef95dc511cda475672

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/394072

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/newton)

Reviewed: https://review.openstack.org/394072
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=909ed04c96fdf46d39645a79c7ef4c988fa04877
Submitter: Jenkins
Branch: stable/newton

commit 909ed04c96fdf46d39645a79c7ef4c988fa04877
Author: Kevin Benton <email address hidden>
Date: Thu Sep 29 01:37:59 2016 -0700

    Only mark ports ready on synced networks

    The DHCP agent was previously resending every single port to
    the server whenever sync_state was called, even if it was just
    for one network.

    This let to sending way too much unnecessary data to the server
    and also potentially resulted in sending a port to the server
    that wasn't actually provisioned yet.

    This patch corrects the behavior by only sending ports for networks
    that are being synced if it's a conditional sync.

    Closes-Bug: #1639086
    Change-Id: Ie7686837b18ff251baa315ef95dc511cda475672
    (cherry picked from commit 7dc2707c2b0b05ad7699a24680a5b45e67f717fc)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 10.0.0.0b1

This issue was fixed in the openstack/neutron 10.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 9.1.1

This issue was fixed in the openstack/neutron 9.1.1 release.

tags: added: neutron-proactive-backport-potential
tags: removed: neutron-proactive-backport-potential newton-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.