Swift services are down after Mitaka to Newton controller upgrade

[Marios Andreou]

As first discussed at https://bugzilla.redhat.com/show_bug.cgi?id=1386719#c5 after the controller upgrade step has been completed, swift services are not started as expected on controllers. There are no stand-alone swift nodes in this deployment, so all swift services are expected on the controllers.

In Mitaka, we used to set the 'enable_swift_storage' hiera for controllers: https://github.com/openstack/tripleo-heat-templates/blob/052e0f02bb85c9caade3017698e7ef7c404280f6/puppet/controller.yaml#L1118 and this is used to determine whether swift will be restarted @ https://github.com/openstack/tripleo-heat-templates/blob/master/extraconfig/tasks/pacemaker_common_functions.sh#L287

However we no longer set this in Newton and instead set the tripleo::profile::base::swift::storage::enable_swift_storage parameter: https://github.com/openstack/tripleo-heat-templates/blob/82e262dff234bae5b1c892d1943fbd50e61801f6/puppet/services/swift-storage.yaml#L69 (& puppet-tripleo @ https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/swift/storage.pp#L32).

Fixup @ "Fixup the start of swift services" https://review.openstack.org/#/c/392680/ Id1383c1e54f9cae13fd375e90da525230e5d23eb tripleo-heat-templates

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/393760

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/392680
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a7af5b90e4fa432973a7ab2f27df5427387b01c0
Submitter: Jenkins
Branch: master

commit a7af5b90e4fa432973a7ab2f27df5427387b01c0
Author: marios <email address hidden>
Date: Wed Nov 2 16:23:30 2016 +0200

    Fixup the start of swift services

    Seems the conditional has changed and we should pickup the
    tripleo::profile::base::swift::storage::enable_swift_storage
    hiera data.

    After controller nodes are upgraded the swift services were down
    even though there was no stand-alone swift node (the current
    conditional was failing as that hiera isn't set any more)

    Closes-Bug: 1638821
    Change-Id: Id1383c1e54f9cae13fd375e90da525230e5d23eb

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/393760
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3f9edbf910658e5f62988ac3f3268b26385f5636
Submitter: Jenkins
Branch: stable/newton

commit 3f9edbf910658e5f62988ac3f3268b26385f5636
Author: marios <email address hidden>
Date: Wed Nov 2 16:23:30 2016 +0200

    Fixup the start of swift services

    Seems the conditional has changed and we should pickup the
    tripleo::profile::base::swift::storage::enable_swift_storage
    hiera data.

    After controller nodes are upgraded the swift services were down
    even though there was no stand-alone swift node (the current
    conditional was failing as that hiera isn't set any more)

    Closes-Bug: 1638821
    Change-Id: Id1383c1e54f9cae13fd375e90da525230e5d23eb
    (cherry picked from commit a7af5b90e4fa432973a7ab2f27df5427387b01c0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.1.0 release.