The ""sort" can not work in policy binding list

Bug #1638438 reported by miaohb
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack SDK
Fix Released
Undecided
miaohb
python-senlinclient
Fix Committed
Medium
miaohb

Bug Description

In the help message of "policy binding list", the option "sort" is listed. However, none of the "sort keys" can work actually.

stack@tecs:/root$ openstack cluster policy binding list -h
usage: openstack cluster policy binding list [-h]
                                             [-f {csv,json,table,value,yaml}]
                                             [-c COLUMN]
                                             [--max-width <integer>]
                                             [--noindent]
                                             [--quote {all,minimal,none,nonnumeric}]
                                             [--filters <key1=value1;key2=value2...>]
                                             [--sort <key>[:<direction>]]
                                             [--full-id]
                                             <cluster>

List policies from cluster.

positional arguments:
  <cluster> Name or ID of cluster to query on

optional arguments:
  -h, --help show this help message and exit
  --filters <key1=value1;key2=value2...>
                        Filter parameters to apply on returned results. This
                        can be specified multiple times, or once with
                        parameters separated by a semicolon. The valid filter
                        keys are: ['type', 'name']
  --sort <key>[:<direction>]
                        Sorting option which is a string containing a list of
                        keys separated by commas. Each key can be optionally
                        appended by a sort direction (:asc or :desc). The
                        valid sort keys are: ['type', 'name', 'created_at',
                        'updated_at']

miaohb (miao-hongbao)
Changed in senlin:
status: New → In Progress
assignee: nobody → miaohb (miao-hongbao)
miaohb (miao-hongbao)
Changed in python-senlinclient:
status: New → In Progress
assignee: nobody → miaohb (miao-hongbao)
miaohb (miao-hongbao)
Changed in python-openstacksdk:
status: New → In Progress
assignee: nobody → miaohb (miao-hongbao)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstacksdk (master)

Fix proposed to branch: master
Review: https://review.openstack.org/393980

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-senlinclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/393981

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstacksdk (master)

Reviewed: https://review.openstack.org/393980
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=4dd9af3a120e5300a4dcd8f3bbfb0044808ac5a3
Submitter: Jenkins
Branch: master

commit 4dd9af3a120e5300a4dcd8f3bbfb0044808ac5a3
Author: miaohb <email address hidden>
Date: Sat Nov 5 13:09:22 2016 +0800

    Add "sort" in policy binding list

    Add "sort" in queryparameters, add "sort" related unit test

    Change-Id: I554c4b3c486cf5addd1a2ffed6284cbc176f6e82
    Closed-Bug: 1638438

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-senlinclient (master)

Reviewed: https://review.openstack.org/393981
Committed: https://git.openstack.org/cgit/openstack/python-senlinclient/commit/?id=374a474e51bbab35cb53260d43be99a2e0862931
Submitter: Jenkins
Branch: master

commit 374a474e51bbab35cb53260d43be99a2e0862931
Author: miaohb <email address hidden>
Date: Thu Nov 3 20:18:43 2016 +0800

    Revise the help message of policy binding list

    In the current version, the valid sort key is "enabled" only.

    Depends-On: I554c4b3c486cf5addd1a2ffed6284cbc176f6e82
    Closed-Bug: 1638438
    Change-Id: I4749bd34484e98571c3a4f101e899813c72dd0b6

Revision history for this message
Qiming Teng (tengqim) wrote :

do we still need a server side fix for this?

Changed in python-openstacksdk:
status: In Progress → Fix Released
Changed in python-senlinclient:
status: In Progress → Fix Committed
importance: Undecided → Medium
Revision history for this message
miaohb (miao-hongbao) wrote :

No, thanks.

no longer affects: senlin
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.