Pressing "center" button to fast in message window leads to crash
Bug #1638409 reported by
Notabilis
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
When opening the message window, the "center on event"-button is enabled even without messages, until think() is called by the game loop. If the button is pressed in between, the game will crash.
To reproduce start a game and press "n" + "g" very fast without messages in the inbox. Sooner or later you are fast enough and the game will crash.
The linked branch fixes this issue by disabling the button per default. It becomes enabled again on next call of think() if a message is present.
Related branches
lp:~notabilis27/widelands/bug-message-window
- GunChleoc: Approve
-
Diff: 11 lines (+1/-0)1 file modifiedsrc/wui/game_message_menu.cc (+1/-0)
Revision history for this message
| GunChleoc (gunchleoc) wrote | #1 |
| Changed in widelands: | |
| milestone: | none → build20-rc1 |
| tags: | added: crash ui |
| Changed in widelands: | |
| status: | New → Triaged |
| Changed in widelands: | |
| status: | Triaged → Fix Committed |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #2 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Confirmed and fix LGTM. I have started a merge request to get our test running.
This bug is not present in the b19 branch.