ShowServiceChain introspect shows incorrect info for pending chains

[Nischal Sheth]

There are 2 problems with the out of ShowServiceChain introspect:

1. If the pending keyword is used, it does not show any information
about source, destination and connected routing instances.

2. If the pending keyword is not used, the source, destination and
connected routing instances for pending service chains are wrong.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25502
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25503
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25504
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25505
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25503
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25505
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25504
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25502
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25518
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/25505
Committed: http://github.org/Juniper/contrail-controller/commit/879e0bc73618d0e3f7275cd8f49de1b378f97e5f
Submitter: Zuul
Branch: R3.1

commit 879e0bc73618d0e3f7275cd8f49de1b378f97e5f
Author: Nischal Sheth <email address hidden>
Date: Fri Oct 28 11:56:46 2016 -0700

Fix issues with output of ShowServiceChain introspect

There were a couple of related issues:

1. If the pending keyword was used as a search string, the output would
not show any information about source, destination and connected routing
instances.

Fix this by filling in the information from service chain configuration
instead of operational state.

2. If the pending keyword was not used, the output for pending chains
would have wrong values for source, destination and connected routing
instances.

Fix this by changing the scope of local variable in FillServiceChainInfo.

Change-Id: I7159b74e0dfd020bca8c37ac6f7fca910d32cce7
Closes-Bug: 1637613

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/25502
Committed: http://github.org/Juniper/contrail-controller/commit/aa7af8080be8472f1397b9e1727e6ca316a5b02f
Submitter: Zuul
Branch: master

commit aa7af8080be8472f1397b9e1727e6ca316a5b02f
Author: Nischal Sheth <email address hidden>
Date: Fri Oct 28 11:56:46 2016 -0700

Fix issues with output of ShowServiceChain introspect

There were a couple of related issues:

1. If the pending keyword was used as a search string, the output would
not show any information about source, destination and connected routing
instances.

Fix this by filling in the information from service chain configuration
instead of operational state.

2. If the pending keyword was not used, the output for pending chains
would have wrong values for source, destination and connected routing
instances.

Fix this by changing the scope of local variable in FillServiceChainInfo.

Change-Id: I7159b74e0dfd020bca8c37ac6f7fca910d32cce7
Closes-Bug: 1637613

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/25504
Committed: http://github.org/Juniper/contrail-controller/commit/9ceec0b72fd3878d3fd3ac19cf1bc58978480222
Submitter: Zuul
Branch: R3.0

commit 9ceec0b72fd3878d3fd3ac19cf1bc58978480222
Author: Nischal Sheth <email address hidden>
Date: Fri Oct 28 11:56:46 2016 -0700

Fix issues with output of ShowServiceChain introspect

There were a couple of related issues:

1. If the pending keyword was used as a search string, the output would
not show any information about source, destination and connected routing
instances.

Fix this by filling in the information from service chain configuration
instead of operational state.

2. If the pending keyword was not used, the output for pending chains
would have wrong values for source, destination and connected routing
instances.

Fix this by changing the scope of local variable in FillServiceChainInfo.

Change-Id: I7159b74e0dfd020bca8c37ac6f7fca910d32cce7
Closes-Bug: 1637613

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/25518
Committed: http://github.org/Juniper/contrail-controller/commit/a9ffc1d1b309aef3f999727f2201f4977ff3c7af
Submitter: Zuul
Branch: R3.2

commit a9ffc1d1b309aef3f999727f2201f4977ff3c7af
Author: Nischal Sheth <email address hidden>
Date: Fri Oct 28 11:56:46 2016 -0700

Fix issues with output of ShowServiceChain introspect

There were a couple of related issues:

1. If the pending keyword was used as a search string, the output would
not show any information about source, destination and connected routing
instances.

Fix this by filling in the information from service chain configuration
instead of operational state.

2. If the pending keyword was not used, the output for pending chains
would have wrong values for source, destination and connected routing
instances.

Fix this by changing the scope of local variable in FillServiceChainInfo.

Change-Id: Icbea734c09b8570ab4eff8b576ac3c478459f124
Closes-Bug: 1637613