Simplify Ironic Node Registration Code in Tripleo-common

Bug #1637310 reported by Toure Dunnon
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Expired
Undecided
Unassigned

Bug Description

Port methods from tripleo-common/utils/nodes.py into a workflow level tasks or tripleo-common actions, this will add support for improvements to node registration workflows.

Tags: workflows
Revision history for this message
Steven Hardy (shardy) wrote :

We should also discuss with Ironic folks to see what (if any) logic can be refactored into a non TripleO specific location?

Changed in tripleo:
milestone: none → ocata-1
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-common (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/395060

Steven Hardy (shardy)
Changed in tripleo:
milestone: ocata-1 → ocata-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/395060
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=a2e6c7d603b1d7fa6797c9ba85e1e6387e83f204
Submitter: Jenkins
Branch: master

commit a2e6c7d603b1d7fa6797c9ba85e1e6387e83f204
Author: Dmitry Tantsur <email address hidden>
Date: Tue Nov 8 17:02:21 2016 +0100

    Remove unused bits from node management code in utils/node.py

    * Removed set_nodes_state and wait_for_provision_state functions
      as this code was moved to workflows
    * Removed "provide", "keystone_client" and "blocking" arguments and
      default value for "client" argument from register_all_nodes.
    * Removed "blocking" argument and default value for "client" argument
      from register_ironic_node.

    Change-Id: I23896b649958fdabf5cc0e2488101e56c4d5b313
    Related-Bug: #1637310

Dougal Matthews (d0ugal)
Changed in tripleo:
assignee: nobody → Dougal Matthews (d0ugal)
Dougal Matthews (d0ugal)
Changed in tripleo:
assignee: Dougal Matthews (d0ugal) → nobody
Changed in tripleo:
milestone: ocata-2 → ocata-3
Changed in tripleo:
milestone: ocata-3 → pike-1
Changed in tripleo:
milestone: pike-1 → pike-2
Brad P. Crochet (brad-9)
Changed in tripleo:
assignee: nobody → Brad P. Crochet (brad-9)
Changed in tripleo:
milestone: pike-2 → pike-3
Revision history for this message
Emilien Macchi (emilienm) wrote :

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

Changed in tripleo:
assignee: Brad P. Crochet (brad-9) → nobody
Changed in tripleo:
milestone: pike-3 → pike-rc1
Changed in tripleo:
milestone: pike-rc1 → queens-1
Changed in tripleo:
milestone: queens-1 → queens-2
Changed in tripleo:
milestone: queens-2 → queens-3
Changed in tripleo:
milestone: queens-3 → queens-rc1
Changed in tripleo:
milestone: queens-rc1 → rocky-1
Changed in tripleo:
milestone: rocky-1 → rocky-2
Changed in tripleo:
milestone: rocky-2 → rocky-3
Changed in tripleo:
milestone: rocky-3 → rocky-rc1
Changed in tripleo:
milestone: rocky-rc1 → stein-1
Dougal Matthews (d0ugal)
Changed in tripleo:
importance: Medium → Low
Changed in tripleo:
milestone: stein-1 → stein-2
Revision history for this message
Emilien Macchi (emilienm) wrote : Cleanup EOL bug report

This is an automated cleanup. This bug report has been closed because it
is older than 18 months and there is no open code change to fix this.
After this time it is unlikely that the circumstances which lead to
the observed issue can be reproduced.

If you can reproduce the bug, please:
* reopen the bug report (set to status "New")
* AND add the detailed steps to reproduce the issue (if applicable)
* AND leave a comment "CONFIRMED FOR: <RELEASE_NAME>"
  Only still supported release names are valid (FUTURE, PIKE, QUEENS, ROCKY, STEIN).
  Valid example: CONFIRMED FOR: FUTURE

Changed in tripleo:
importance: Low → Undecided
status: Triaged → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.