broken when directory contains files with exclamation mark (!)

[Valentas]

typing vim and hitting tab displays no local files if the directory contains a file that starts with an exclamation mark. See also a question by another user http://askubuntu.com/questions/840866/vi-tab-completion-works-only-in-some-directories.

[Valentas (vk-registrator)]

bash-completion version: 1:2.1-4.2ubuntu1.1

[Andrey Sidorov (andrey-desman)]

Fixed by extra-quoting $xspec.

$ diff -u bash_completion /usr/share/bash-completion/bash_completion
--- bash_completion 2016-11-29 21:48:11.787460446 +0300
+++ /usr/share/bash-completion/bash_completion 2016-11-29 21:44:51.755183840 +0300
@@ -1845,7 +1845,7 @@
     xspec="$matchop($xspec|${xspec^^})"

     toks+=( $(
- eval compgen -f -X "!$xspec" -- "\$(quote_readline "\$cur")" | {
+ eval compgen -f -X "\'!$xspec\'" -- "\$(quote_readline "\$cur")" | {
         while read -r tmp; do
             [[ -n $tmp ]] && printf '%s\n' $tmp
         done

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.