Maintenance status not shown in "Assign nodes" screen

[Julie Pichon]

When assigning a role to nodes in the UI, all nodes are shown regardless of maintenance status. This is probably fine, however whether there is no visual indication if a node is truly available or off for maintenance.

Steps to reproduce:
-------------------
1. Switch an available node to maintenance
$ ironic node-set-maintenance <node_uuid> on
2. Go the deployment plan and click Assign Role for any role

Expected result:
----------------
3. The node on maintenance is on the list, but the 'maintenance' status is clearly indicated.

Actual result:
--------------
3. The node on maintenance is on the list, shown as available and looks exactly the nodes that are deployable.

I think this will create unexpected results when deploying.

[Ana Krivokapić (akrivoka)]

Since the maintenance nodes are filtered out in the Nodes table, do we want to simply also exclude them from the Assign Nodes dialog? I think it would make sense.

[Ana Krivokapić (akrivoka)]

Oh now I see that they are actually moved to a separate tab and not filtered out. Never mind.

[Liz Blanchard (lblanchard)]

The proposed wireframe shows the different states that could be shown including whether a node is in maintenance or not. Also, this will show any tags or role assignment:
https://openstack.invisionapp.com/share/PA99PGMZV#/203867080_2016-11-4_TripleO_UI15

Thoughts?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/431515

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/431515
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=da08626267a89e4851f1e0707341b1a2d53365eb
Submitter: Jenkins
Branch: master

commit da08626267a89e4851f1e0707341b1a2d53365eb
Author: Jiri Tomasek <email address hidden>
Date: Thu Feb 9 13:40:01 2017 +0100

    Cleanup Nodes selectors

    * unify and simplify selectors which work with node capabilities
    * replace non selector getAssingedNodes with getAvailableNodesByRole
      selector
    * fix available nodes selector, to filter on registeredNodes as
      deployed and maintenance nodes are not considered available for
      deployment

    Closes-Bug: #1637131
    Change-Id: Ib057129dd5f813801ee58a0f64218c7ed9ecf5c6

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/439591

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/439591
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=6c30b2a575a239758eac4f309f330cd60190eaa9
Submitter: Jenkins
Branch: stable/ocata

commit 6c30b2a575a239758eac4f309f330cd60190eaa9
Author: Jiri Tomasek <email address hidden>
Date: Thu Feb 9 13:40:01 2017 +0100

    Cleanup Nodes selectors

    * unify and simplify selectors which work with node capabilities
    * replace non selector getAssingedNodes with getAvailableNodesByRole
      selector
    * fix available nodes selector, to filter on registeredNodes as
      deployed and maintenance nodes are not considered available for
      deployment

    Closes-Bug: #1637131
    Change-Id: Ib057129dd5f813801ee58a0f64218c7ed9ecf5c6
    (cherry picked from commit da08626267a89e4851f1e0707341b1a2d53365eb)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ui 3.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ui 7.0.0 release.