Show results from All Libraries option should not display when search scope is set to the consortium

[Kathy Lussier]

In tsbere's initial code to add the Show results from All Libraries option to the search results screen, the code was set to not display the option if a search scope was set to the consortium. http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=15ee634667f8df14e6595f4d53218834477fd23b

However, after adding options to config.tt2 where libraries could set the depth that's applied to the search as a result of selecting the option, this piece was removed.

The "Show results from All Libraries" checkbox displays even if the original scope of the search was set to the consortium. This is confusing to users because selecting the option results in no changes in the search result set.

I assume the reason the [% IF loc_value != 1 %] bit was removed is because, with the optional depth, it is no longer safe to say that the option will always expand the search to the entire consortium.

I'm thinking the best approach might be to add yet another config.tt2 setting that identifies the loc value at which the option should not display. Or is there a better way to handle this?

[Thomas Berezansky (tsbere)]

Another reason it always shows was that it was deemed "confusing" to have the option coming and going by some of those looking at it.

One option would be to disable the checkbox if the search scope is set to a depth that equals the depth the checkbox would set.

[Michele Morgan (mmorgan)]

Marking Confirmed. Still an issue in both Bootstrap catalog and TPAC in 3.7.