Print a warning when validation runs on zero nodes / print nodes used

Bug #1636849 reported by Attila Darazs
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Katerina Pilatova

Bug Description

Due to a dynamic inventory bug, no overcloud nodes got passed to the validation playbook. Despite this it returned with a message that implied that the validation ran successfully, despite not running at all on any nodes This is quite misleading. Would be better to print out the nodes it ran on for an improved output.

Example problem:

$ ./scripts/tripleo-ansible-inventory --list
{"undercloud": {"hosts": ["localhost"], "vars": {"ansible_connection": "local", "public_vip": "10.0.0.7"}}}
$ ansible-playbook -i scripts/tripleo-ansible-inventory validations/mysql-open-files-limit.yaml
Success! The validation passed for all hosts.

Tags: validations
Tomas Sedovic (tsedovic)
Changed in tripleo:
status: New → Triaged
importance: Undecided → High
milestone: none → ocata-1
Revision history for this message
Tomas Sedovic (tsedovic) wrote :

In addition to that, if there is one host with a failure and all the others are successful, the summary message lists all hosts as failed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (master)

Fix proposed to branch: master
Review: https://review.openstack.org/396135

Changed in tripleo:
assignee: nobody → Katerina Pilatova (kpilatov)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (master)

Reviewed: https://review.openstack.org/396135
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=d6f10a2ab0272f1a7032559db67a74b38c966988
Submitter: Jenkins
Branch: master

commit d6f10a2ab0272f1a7032559db67a74b38c966988
Author: Katerina Pilatova <email address hidden>
Date: Thu Nov 10 12:44:26 2016 +0100

    callback_plugins/validation_output.py: improved output

    - when the validation is successful, all hosts are listed in the output
    - when the validation does not run on any host, output contains a warning
    - when the validation fails, both hosts where it passed and where it failed are listed

    Change-Id: I69368d2c56d4f014d0dde78b8662146fcf686751
    Closes-Bug: #1636849

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations 5.2.0

This issue was fixed in the openstack/tripleo-validations 5.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.