CephClusterFSID missing from the generated passwords list

[Julie Pichon]

This is coming up when deploying with a plan and including a Ceph node, see bug 1626426. The deployment fails because the property is not set.

It looks like the client's "overcloud deploy" command is generating the parameter automatically at https://github.com/openstack/python-tripleoclient/blob/1969cc/tripleoclient/v1/overcloud_deploy.py#L129 and adding it to the Mistral environment at deploy time.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/390612

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/390612
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=49d23e0821ed8662e4b4ef43368251f3efb7fe0a
Submitter: Jenkins
Branch: master

commit 49d23e0821ed8662e4b4ef43368251f3efb7fe0a
Author: Julie Pichon <email address hidden>
Date: Tue Oct 25 17:23:46 2016 +0100

    Add CephClusterFSID to generated passwords

    Deployments with a Ceph Storage component fail without this parameter.
    Currently it's generated automatically when deploying with the CLI,
    this re-uses the same code.

    Change-Id: Icb93d336a35ce6ec393023b88cea34df4810f391
    Closes-Bug: #1636555
    Related-Bug: #1626426

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/394493

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/394493
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=79bd89a0a1a46bebd06e0e8ed68e96f4345a52cb
Submitter: Jenkins
Branch: stable/newton

commit 79bd89a0a1a46bebd06e0e8ed68e96f4345a52cb
Author: Julie Pichon <email address hidden>
Date: Tue Oct 25 17:23:46 2016 +0100

    Add CephClusterFSID to generated passwords

    Deployments with a Ceph Storage component fail without this parameter.
    Currently it's generated automatically when deploying with the CLI,
    this re-uses the same code.

    Change-Id: Icb93d336a35ce6ec393023b88cea34df4810f391
    Closes-Bug: #1636555
    Related-Bug: #1626426
    (cherry picked from commit 49d23e0821ed8662e4b4ef43368251f3efb7fe0a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 5.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 5.5.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/400419

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/400419
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=20167e850a6bcb1fbb1bfa8cb030000600c3dc27
Submitter: Jenkins
Branch: master

commit 20167e850a6bcb1fbb1bfa8cb030000600c3dc27
Author: Giulio Fidente <email address hidden>
Date: Mon Nov 21 22:49:12 2016 +0100

    Generate CephClusterFSID for new stacks

    This parameter is needed for new deployments using Ceph, but it
    should not change across updates/upgrades.

    Change-Id: I2ac62d47922f7dc1d37b2da313fd35f08debfab4
    Closes-Bug: #1636555
    Related-Bug: #1643701

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/400676

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/400766

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/400676
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=c8d54e9a8353eb54d7fe377ae935712af241eb52
Submitter: Jenkins
Branch: stable/newton

commit c8d54e9a8353eb54d7fe377ae935712af241eb52
Author: Giulio Fidente <email address hidden>
Date: Mon Nov 21 22:49:12 2016 +0100

    Generate CephClusterFSID for new stacks

    This parameter is needed for new deployments using Ceph, but it
    should not change across updates/upgrades.

    Change-Id: I2ac62d47922f7dc1d37b2da313fd35f08debfab4
    Closes-Bug: #1636555
    Related-Bug: #1643701
    (cherry picked from commit 20167e850a6bcb1fbb1bfa8cb030000600c3dc27)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/401212

[OpenStack Infra (hudson-openstack)]

Change abandoned by Giulio Fidente (<email address hidden>) on branch: master
Review: https://review.openstack.org/400766
Reason: Fixed by I3ea6bbd0d9c5dd345b8a4a26a1788326e09d4209

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/401267

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/401212
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=e1c07fc453e5113782fb0d22cd4a487260f68579
Submitter: Jenkins
Branch: master

commit e1c07fc453e5113782fb0d22cd4a487260f68579
Author: Dougal Matthews <email address hidden>
Date: Wed Nov 23 11:26:11 2016 +0000

    Revert changes to CephClusterFSID generation

    This patch reverts the two commits listed below. There was a problem
    with CephClusterFSID generation as it was created by the password
    generation code in Mistral in Newton. However, this password generation
    didn't work for upgrades as it didn't take into account upgrades and
    passwords that were in use in an existing Heat stack.

    This issue was resolved in I3ea6bbd0d9c5dd345b8a4a26a1788326e09d4209.
    Now when a deployment plan is created, if there is an existing Heat
    stack it takes the parameters from the Heat stack and uses those, rather
    than regenerating. This change should also resolve the issue where the
    CephClusterFSID was regenerated.

    Revert "Generate CephClusterFSID for new stacks"
    This reverts commit 20167e850a6bcb1fbb1bfa8cb030000600c3dc27.

    Revert "Revert "Add CephClusterFSID to generated passwords""
    This reverts commit ad64050485f79d2330c68b76a3f21b4c0d9a3e33.

    Related-Bug: #1636555
    Change-Id: I10b5613eda4bd47554a4f5e9f57218010b835fe7

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/401267
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=e10fd44007291b65dd3df74cc4c999732eac622f
Submitter: Jenkins
Branch: stable/newton

commit e10fd44007291b65dd3df74cc4c999732eac622f
Author: Dougal Matthews <email address hidden>
Date: Wed Nov 23 11:26:11 2016 +0000

    Revert changes to CephClusterFSID generation

    This patch reverts the two commits listed below. There was a problem
    with CephClusterFSID generation as it was created by the password
    generation code in Mistral in Newton. However, this password generation
    didn't work for upgrades as it didn't take into account upgrades and
    passwords that were in use in an existing Heat stack.

    This issue was resolved in I3ea6bbd0d9c5dd345b8a4a26a1788326e09d4209.
    Now when a deployment plan is created, if there is an existing Heat
    stack it takes the parameters from the Heat stack and uses those, rather
    than regenerating. This change should also resolve the issue where the
    CephClusterFSID was regenerated.

    Revert "Generate CephClusterFSID for new stacks"
    This reverts commit 20167e850a6bcb1fbb1bfa8cb030000600c3dc27.

    Revert "Revert "Add CephClusterFSID to generated passwords""
    This reverts commit ad64050485f79d2330c68b76a3f21b4c0d9a3e33.

    Related-Bug: #1636555
    Change-Id: I10b5613eda4bd47554a4f5e9f57218010b835fe7
    (cherry picked from commit e1c07fc453e5113782fb0d22cd4a487260f68579)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 5.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 5.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 5.4.1 release.