OpenStack Dashboard (Horizon)

In case of choosing no file, script error will occur

Bug #1636340 reported by Kenji Ishii on 2016-10-25

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	Low	Kenji Ishii	OpenStack Dashboard (Horizon) ocata-2 "o-2"

Bug Description

When uploading file in swift container panel, a user choose a file to upload.
In that case, when a user select no file with opening select file dialog, script error occur.

The following code always expects to have a file info.
https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/static/dashboard/project/containers/file-change-directive.js#L62

Tags:

Kenji Ishii (ken-ishii) on 2016-10-25

Changed in horizon:
assignee:	nobody → Kenji Ishii (ken-ishii)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-25: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/390422

Changed in horizon:
status:	New → In Progress

Rob Cresswell (robcresswell-deactivatedaccount) on 2016-11-01

Changed in horizon:
importance:	Undecided → Low
milestone:	none → ocata-3
milestone:	ocata-3 → ocata-1

Rob Cresswell (robcresswell-deactivatedaccount) on 2016-11-21

Changed in horizon:
milestone:	ocata-1 → ocata-2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-23: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/390422
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2fbf3fbdf3da2371219da3bc6509e1b622175f5e
Submitter: Jenkins
Branch: master

commit 2fbf3fbdf3da2371219da3bc6509e1b622175f5e
Author: Kenji Ishii <email address hidden>
Date: Tue Oct 25 10:32:10 2016 +0900

Fix a script error which is occurred when choosing no file

    In swift container panel, when a user select no file with opening
    file select dialog, error will occur because in that case there
    are no file info. This patch will fix it.

Change-Id: Ib6e381e9af97837f6aae8df9d9564eee76304670
Closes-Bug: #1636340

Changed in horizon:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-16: Fix proposed to horizon (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/420783

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-20: Fix merged to horizon (stable/newton)

Reviewed: https://review.openstack.org/420783
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=620ecfab372f931cd7e9507d45c10d456e0101fa
Submitter: Jenkins
Branch: stable/newton

commit 620ecfab372f931cd7e9507d45c10d456e0101fa
Author: Kenji Ishii <email address hidden>
Date: Tue Oct 25 10:32:10 2016 +0900

Fix a script error which is occurred when choosing no file

    In swift container panel, when a user select no file with opening
    file select dialog, error will occur because in that case there
    are no file info. This patch will fix it.

    Change-Id: Ib6e381e9af97837f6aae8df9d9564eee76304670
    Closes-Bug: #1636340
    (cherry picked from commit 2fbf3fbdf3da2371219da3bc6509e1b622175f5e)