Network Configuration tab should only appear when Network Isolation is selected

[Dan Trainor]

Relates to recent work done in https://bugs.launchpad.net/tripleo/+bug/1626755

The Network Configuration tab should only be exposed when Deployment Configuration -> Overall Settings -> Overlay Network Configuration -> Network Isolation is selected. When the dialogue is displayed, the form field contents should be pre-populated with what's in the currently used Deployment Plan. This data will be whatever is present in the plan templates, which can either be the pre-configured values that someone enters, or the default values in the plan.

[Jiri Tomasek (jtomasek)]

If you see network configuration parameters which resemble to network isolation in network configuration tab, it means that default environment (overcloud-resource-registry-puppet.j2.yaml) references templates which already define those parameters. This might be the problem, but it needs to get resolved in the templates.

About the defaults for network configuration parameters - when you look at templates reefrenced in network-configuration.yaml, you can see, that their default value is set to ''. Which is what GUI displays when you enable network isolation. AFAIK, it is expected that in addition to network-isolation, user also enables additional environments from the 'Single NIC or Bonding group' when you do this, you can see how the parameters get populated with default values in 'Network Configuration' tab.

The conclusion should IMHO be that to achieve the desired behavior, we need to make sure, the environments and templates are better structured. The environment dependency problem has been discussed on Barcelona Summit and plan is to improve this. Although, the root of the problem seems to be in isolation parameters being defined in templates referenced by default environment.

[Liz Blanchard (lblanchard)]

Wanted to add the latest Network Configuration mock ups to this bug for discussion sake:
https://lizsurette.github.io/OpenStack-Design/tripleo-ui/3-tripleo-ui-edge-cases/7.advancednetworkconfigurationandtopology

[Emilien Macchi (emilienm)]

This is an automated cleanup. This bug report has been closed because it
is older than 18 months and there is no open code change to fix this.
After this time it is unlikely that the circumstances which lead to
the observed issue can be reproduced.

If you can reproduce the bug, please:
* reopen the bug report (set to status "New")
* AND add the detailed steps to reproduce the issue (if applicable)
* AND leave a comment "CONFIRMED FOR: <RELEASE_NAME>"
  Only still supported release names are valid (FUTURE, PIKE, QUEENS, ROCKY, STEIN).
  Valid example: CONFIRMED FOR: FUTURE