openstack overcloud update stack does not update plan witch changed THT

[Ryan Brady]

Description of problem:
Update of older deploy of OSP10 will fail as there was change in puppet-ceph, puppet-tripleo and subsequently tripleo-heat-templates which won't cause update of the plan and will fail.

Steps to Reproduce:
1. /usr/share/openstack-tripleo-heat-templates/puppet/services/ceph-base.yaml
        ceph::profile::params::fsid: {get_param: CephClusterFSID}
        # NOTE: bind IP is found in Heat replacing the network name with the local node IP
        # for the given network; replacement examples (eg. for internal_api):
        # internal_api -> IP
        # internal_api_uri -> [IP]
        # internal_api_subnet - > IP/CIDR
        ceph::profile::params::cluster_network:
2. swift download overcloud puppet/services/ceph-base.yaml
        ceph::profile::params::fsid: {get_param: CephClusterFSID}
        # NOTE: bind IP is found in Heat replacing the network name with the local node IP
        # for the given network; replacement examples (eg. for internal_api):
        # internal_api -> IP
        # internal_api_uri -> [IP]
        # internal_api_subnet - > IP/CIDR
        ceph::profile::params::cluster_network:
3. overcloud upgrade -> /usr/share/openstack-tripleo-heat-templates/puppet/services/ceph-base.yaml
        ceph::profile::params::fsid: {get_param: CephClusterFSID}
        # FIXME(gfidente): we should not have to list the packages explicitly in the templates,
        # but this has to stay until https://bugs.launchpad.net/puppet-ceph/+bug/1629933 is fixed
        ceph::params::packages:
          - ceph-base
          - ceph-mon
          - ceph-osd
        # NOTE: bind IP is found in Heat replacing the network name with the local node IP
4. overcloud update -> puppet/services/ceph-base.yaml
        ceph::profile::params::fsid: {get_param: CephClusterFSID}
        # NOTE: bind IP is found in Heat replacing the network name with the local node IP
        # for the given network; replacement examples (eg. for internal_api):
        # internal_api -> IP
        # internal_api_uri -> [IP]
        # internal_api_subnet - > IP/CIDR
        ceph::profile::params::cluster_network:

We need to update the plan from changed templates otherwise we'll hit more issues like this.

[Ryan Brady (rbrady)]

After additional research it looks like the correct steps would be to:
1) update tripleo-heat-templates on undercloud
2) do a deploy (which would update the plan)
3) run the update.

If the deploy doesn't automatically update the plan, then delete plan, deploy, update packages.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/389830

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/389830
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=5c53f2304007546baab19bd992e2f84cf16871f2
Submitter: Jenkins
Branch: master

commit 5c53f2304007546baab19bd992e2f84cf16871f2
Author: Brad P. Crochet <email address hidden>
Date: Fri Oct 21 14:56:31 2016 -0400

    Add a flag to allow the plan to be updated without deploying

    This is a stop-gap flag to allow just the plan to be updated. It will
    cause the 'deploy' command to do everything up to the point of deploying.

    Ideally, there needs to be an 'overcloud plan update' command, but there
    currently would be far too much code to duplicate between that command
    and the deploy command. They need to be refactored to extract the common
    bits into a workflow.

    Change-Id: I546babfcbd0d5eafcf777e45187dd493fcfdc1a1
    Closes-Bug: #1635301

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/395158

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/395158
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=5c18cf7b2213b59a37946d671888b2138563de34
Submitter: Jenkins
Branch: stable/newton

commit 5c18cf7b2213b59a37946d671888b2138563de34
Author: Brad P. Crochet <email address hidden>
Date: Fri Oct 21 14:56:31 2016 -0400

    Add a flag to allow the plan to be updated without deploying

    This is a stop-gap flag to allow just the plan to be updated. It will
    cause the 'deploy' command to do everything up to the point of deploying.

    Ideally, there needs to be an 'overcloud plan update' command, but there
    currently would be far too much code to duplicate between that command
    and the deploy command. They need to be refactored to extract the common
    bits into a workflow.

    Change-Id: I546babfcbd0d5eafcf777e45187dd493fcfdc1a1
    Closes-Bug: #1635301
    (cherry picked from commit 5c53f2304007546baab19bd992e2f84cf16871f2)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 5.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 5.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 5.4.0 release.