Node update via "baremetal import" fails when some of the existing nodes are in not in "enroll" or "available" state

Bug #1635240 reported by Dmitry Tantsur
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Dmitry Tantsur

Bug Description

Our workflows expect all nodes to be in these states. This is not correct, e.g. when some nodes are deployed to or are in manageable state. We need to only apply "manage" action to nodes in "enroll" state.

Dmitry Tantsur (divius)
summary: - Node update fails when some of the nodes are in not in "enroll" or
- "available" states
+ Node update via "baremetal import" fails when some of the existing nodes
+ are in not in "enroll" or "available" state
Changed in tripleo:
milestone: none → ocata-1
Dmitry Tantsur (divius)
Changed in tripleo:
assignee: nobody → Dmitry Tantsur (divius)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/392179

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/392653

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/392179
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=601a021b0a331fa31bc35984ad44d9eb87d9f031
Submitter: Jenkins
Branch: master

commit 601a021b0a331fa31bc35984ad44d9eb87d9f031
Author: Dmitry Tantsur <email address hidden>
Date: Tue Nov 1 15:29:09 2016 +0100

    Do not try "manage" actions on nodes that are not in "enroll" state

    When updating existing nodes, the register_or_update workflow tries
    "manage" action on them without considering their current state.
    This change fixes it by only running "manage" on nodes in "enroll" state.

    Partial-Bug: #1635240
    Change-Id: I38a52478a6c671c054d08dd15e9bf6226c5dc5d7

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/394429

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/newton)

Reviewed: https://review.openstack.org/394429
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=f1d85243094ab812122887d29485c8d3d46ab16b
Submitter: Jenkins
Branch: stable/newton

commit f1d85243094ab812122887d29485c8d3d46ab16b
Author: Dmitry Tantsur <email address hidden>
Date: Tue Nov 1 15:29:09 2016 +0100

    Do not try "manage" actions on nodes that are not in "enroll" state

    When updating existing nodes, the register_or_update workflow tries
    "manage" action on them without considering their current state.
    This change fixes it by only running "manage" on nodes in "enroll" state.

    Partial-Bug: #1635240
    Change-Id: I38a52478a6c671c054d08dd15e9bf6226c5dc5d7
    (cherry picked from commit 601a021b0a331fa31bc35984ad44d9eb87d9f031)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/392653
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=11e1c3c6100366a6a783c96b595310aecc38687c
Submitter: Jenkins
Branch: master

commit 11e1c3c6100366a6a783c96b595310aecc38687c
Author: Dmitry Tantsur <email address hidden>
Date: Wed Nov 2 14:18:18 2016 +0100

    Do not try to "provide" updated nodes not in "manageable" state

    The "import" command can update existing nodes, which are not necessary
    in "manageable" state. However, we try to unconditionally run the "provide"
    workflow for such nodes. This change limits it to only "manageable" nodes.

    Change-Id: I15219e53abeb43712b25cb3098334f4805f762b5
    Partial-Bug: #1635240

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/394930

Dmitry Tantsur (divius)
Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/newton)

Reviewed: https://review.openstack.org/394930
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=8a7f46b0be61d1a4882d88b1487c5f0065b78a64
Submitter: Jenkins
Branch: stable/newton

commit 8a7f46b0be61d1a4882d88b1487c5f0065b78a64
Author: Dmitry Tantsur <email address hidden>
Date: Wed Nov 2 14:18:18 2016 +0100

    Do not try to "provide" updated nodes not in "manageable" state

    The "import" command can update existing nodes, which are not necessary
    in "manageable" state. However, we try to unconditionally run the "provide"
    workflow for such nodes. This change limits it to only "manageable" nodes.

    Change-Id: I15219e53abeb43712b25cb3098334f4805f762b5
    Partial-Bug: #1635240
    (cherry picked from commit 11e1c3c6100366a6a783c96b595310aecc38687c)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.